Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2374103002: Temporarily work around crash when adding misspelling annotations to accessible strings (Closed)

Created:
4 years, 2 months ago by dmazzoni
Modified:
4 years, 2 months ago
Reviewers:
nektarios
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily work around crash when adding misspelling annotations to accessible strings BUG=651145 Committed: https://crrev.com/681be131bedcf117065ef1d945395255ad534bb9 Cr-Commit-Position: refs/heads/master@{#422282}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/accessibility/browser_accessibility_cocoa.mm View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
dmazzoni
Nektarios, I'm hoping you can come up with a proper fix for this, but in ...
4 years, 2 months ago (2016-09-28 17:57:26 UTC) #4
nektarios
lgtm
4 years, 2 months ago (2016-09-30 22:51:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374103002/1
4 years, 2 months ago (2016-09-30 22:54:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-01 02:11:12 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-01 02:13:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/681be131bedcf117065ef1d945395255ad534bb9
Cr-Commit-Position: refs/heads/master@{#422282}

Powered by Google App Engine
This is Rietveld 408576698