Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Unified Diff: headless/app/headless_shell.cc

Issue 2374063002: Headless: expose WebPreferences to embedder, add --hide-scrollbars. (Closed)
Patch Set: Address comments, add test. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | headless/app/headless_shell_switches.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: headless/app/headless_shell.cc
diff --git a/headless/app/headless_shell.cc b/headless/app/headless_shell.cc
index 0c9ed16b5ad873ecabe0c361dcde2be8fa7a3b8a..c2e3690f53da75384e55664d2df160acde513ca4 100644
--- a/headless/app/headless_shell.cc
+++ b/headless/app/headless_shell.cc
@@ -75,6 +75,8 @@ class HeadlessShell : public HeadlessWebContents::Observer,
void OnStart(HeadlessBrowser* browser) {
browser_ = browser;
+ HeadlessBrowserContext::Builder context_builder =
+ browser_->CreateBrowserContextBuilder();
if (base::CommandLine::ForCurrentProcess()->HasSwitch(
headless::switches::kDeterministicFetch)) {
deterministic_dispatcher_.reset(
@@ -88,12 +90,16 @@ class HeadlessShell : public HeadlessWebContents::Observer,
base::MakeUnique<headless::DeterministicHttpProtocolHandler>(
deterministic_dispatcher_.get(), browser->BrowserIOThread());
- browser_context_ = browser_->CreateBrowserContextBuilder()
- .SetProtocolHandlers(std::move(protocol_handlers))
- .Build();
- } else {
- browser_context_ = browser_->CreateBrowserContextBuilder().Build();
+ context_builder.SetProtocolHandlers(std::move(protocol_handlers));
+ }
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ headless::switches::kHideScrollbars)) {
+ context_builder.SetOverrideWebPreferencesCallback(
+ base::Bind([](headless::WebPreferences* preferences) {
+ preferences->hide_scrollbars = true;
+ }));
}
+ browser_context_ = context_builder.Build();
HeadlessWebContents::Builder builder(
browser_context_->CreateWebContentsBuilder());
« no previous file with comments | « no previous file | headless/app/headless_shell_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698