Issue 237403002: base: Remove dependency on x11.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 237403002: base: Remove dependency on x11. (Closed)

Created:
6 years, 8 months ago by sadrul

Modified:
6 years, 8 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

base: Remove dependency on x11. All of the X11-dependent code have been removed from base/. So remove the x11 dependency. BUG=354062 R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263793

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -33 lines)			Patch
	M	base/BUILD.gn	View		2 chunks	+0 lines, -12 lines	0 comments	Download
	M	base/base.gyp	View		2 chunks	+0 lines, -21 lines	0 comments	Download

Total messages: 3 (0 generated)

sadrul

https://codereview.chromium.org/235043005/ removes the last bits of X11 dependency from base. Once that lands, it should ...

6 years, 8 months ago (2014-04-14 19:24:19 UTC) #1

sadrul

6 years, 8 months ago (2014-04-15 05:30:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r263793 (presubmit successful).