Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Issue 23740006: Updating endure parser to read new csv output format (Closed)

Created:
7 years, 3 months ago by edmundyan
Modified:
7 years, 3 months ago
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org, qyearsley, anantha
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Visibility:
Public.

Description

Updating endure parser to read new csv output format TEST='scripts/tools/runit.py scripts/slave/unittests/runtest_annotator_test.py GraphingEndureLogProcessorTest' Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=222139

Patch Set 1 #

Total comments: 2

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -19 lines) Patch
M scripts/slave/process_log_utils.py View 1 3 chunks +7 lines, -7 lines 0 comments Download
A + scripts/slave/unittests/data/endure_gmail_alt_two_labels-EventListenerCount-summary.dat View 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/slave/unittests/data/endure_gmail_alt_two_labels-TotalDOMNodeCount-summary.dat View 0 chunks +-1 lines, --1 lines 0 comments Download
A + scripts/slave/unittests/data/endure_gmail_alt_two_labels-V8MemoryUsed-summary.dat View 0 chunks +-1 lines, --1 lines 0 comments Download
M scripts/slave/unittests/data/endure_processor.log View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/unittests/data/endure_processor-graphs_multi.dat View 1 chunk +3 lines, -3 lines 0 comments Download
M scripts/slave/unittests/data/endure_processor_multi.log View 1 chunk +5 lines, -5 lines 0 comments Download
D scripts/slave/unittests/data/https___www_gmail_com_-EventListenerCount-summary.dat View 1 chunk +0 lines, -1 line 0 comments Download
D scripts/slave/unittests/data/https___www_gmail_com_-TotalDOMNodeCount-summary.dat View 1 chunk +0 lines, -1 line 0 comments Download
D scripts/slave/unittests/data/https___www_gmail_com_-V8MemoryUsed-summary.dat View 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/unittests/runtest_annotator_test.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
edmundyan
Michael, how's this look? Our bots are actually already broken because the header line for ...
7 years, 3 months ago (2013-09-05 18:59:58 UTC) #1
Michael Achenbach
lgtm with nit Actually I think we can keep it working with both url and ...
7 years, 3 months ago (2013-09-06 08:34:21 UTC) #2
edmundyan
+xusydoc Hey Mike, could you take a look please? We needed to update our parser ...
7 years, 3 months ago (2013-09-06 16:41:51 UTC) #3
edmundyan
On 2013/09/06 16:41:51, edmundyan wrote: > +xusydoc > > Hey Mike, could you take a ...
7 years, 3 months ago (2013-09-09 19:11:14 UTC) #4
Mike Stip (use stip instead)
lgtm
7 years, 3 months ago (2013-09-10 00:05:27 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/edmundyan@chromium.org/23740006/6001
7 years, 3 months ago (2013-09-10 00:07:06 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-10 00:08:11 UTC) #7
Message was sent while issue was closed.
Change committed as 222139

Powered by Google App Engine
This is Rietveld 408576698