chrome/browser/chromeos/extensions/file_manager/file_tasks.h - Issue 23740004: Files.app: Let the file browser private tasks APIs use the auto-generated helper classes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/file_tasks.h

Issue 23740004: Files.app: Let the file browser private tasks APIs use the auto-generated helper classes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/chromeos/extensions/file_manager/file_tasks.cc » ('j') | chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/file_tasks.h

diff --git a/chrome/browser/chromeos/extensions/file_manager/file_tasks.h b/chrome/browser/chromeos/extensions/file_manager/file_tasks.h

index cd692a6e4644b757309f6e456f6cb52ce3c3b8a7..53343e904c43f76399313f228cce5fea64c24fa6 100644

--- a/chrome/browser/chromeos/extensions/file_manager/file_tasks.h

+++ b/chrome/browser/chromeos/extensions/file_manager/file_tasks.h

@@ -177,21 +177,6 @@ class FullTaskDescriptor {

bool is_default() const { return is_default_; }

void set_is_default(bool is_default) { is_default_ = is_default; }

- // Returns a DictionaryValue representation, which looks like:

- //

- // {

- // "driveApp": true,

- // "iconUrl": "<app_icon_url>",

- // "isDefault": false,

- // "taskId": "<drive_app_id>|drive|open-with",

- // "title": "Drive App Name (ex. Pixlr Editor)"

- // },

- //

- // "iconUrl" is omitted if icon_url_ is empty.

- //

- // This representation will be used to send task info to the JavaScript.

- scoped_ptr<base::DictionaryValue> AsDictionaryValue() const;

private:

TaskDescriptor task_descriptor_;

std::string task_title_;