Files.app: Let the file browser private tasks APIs use the auto-generated helper classes.

Files.app: Let the file browser private tasks APIs use the auto-generated helper classes.

Originally, the file browser private tasks APIs parse the arguments and generate
the results manually.  This CL lets the APIs use the auto generated helper
classes to parse the arguments.

BUG=241693
TEST=file_manager_browsertest

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221635

[hirono, 2013-09-04 13:14:03]

Could you check the CL?
Thank you very much!

[satorux1, 2013-09-05 01:36:52]

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
(right):

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:73: if
(!params->file_urls.size())
if (params->file_urls.empty())

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:112: if
(!params->file_urls.size())
ditto

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:158: for
(size_t i = 0; i < tasks.size(); ++i) {
tasks[i] is references many times in the loop. maybe define:

const FullTaskDescriptor& task = tasks[i];
linked_ptr<FileTask> converted(new FileTask);

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:165:
tasks[i].task_descriptor().task_type ==
please add ()

[hirono, 2013-09-05 03:15:46]

Thanks!

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
(right):

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:73: if
(!params->file_urls.size())
On 2013/09/05 01:36:53, satorux1 wrote:
> if (params->file_urls.empty())

Done.

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:112: if
(!params->file_urls.size())
On 2013/09/05 01:36:53, satorux1 wrote:
> ditto

Done.

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:158: for
(size_t i = 0; i < tasks.size(); ++i) {
On 2013/09/05 01:36:53, satorux1 wrote:
> tasks[i] is references many times in the loop. maybe define:
> 
> const FullTaskDescriptor& task = tasks[i];
> linked_ptr<FileTask> converted(new FileTask);

Done.

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:165:
tasks[i].task_descriptor().task_type ==
On 2013/09/05 01:36:53, satorux1 wrote:
> please add ()

This is removed.

[satorux1, 2013-09-05 03:18:14]

LGTM

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
File chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
(right):

https://codereview.chromium.org/23740004/diff/3001/chrome/browser/chromeos/ex...
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc:165:
tasks[i].task_descriptor().task_type ==
On 2013/09/05 03:15:46, hirono wrote:
> On 2013/09/05 01:36:53, satorux1 wrote:
> > please add ()
> 
> This is removed.

That's right. I just removed it. :)

[kinaba, 2013-09-05 03:22:13]

lgtm

[commit-bot: I haz the power, 2013-09-05 03:30:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/23740004/9001

[commit-bot: I haz the power, 2013-09-05 03:30:39]

Failed to apply patch for
chrome/browser/chromeos/extensions/file_manager/file_tasks.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
  |diff --git a/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
b/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
  |index
20d197ab8840ba5813d8e3b54420d4c3424f5a24..3ba4de4b85a6b7a31c9ce0e88df27b724fdb54d9
100644
  |--- a/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
  |+++ b/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
Index: chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
diff --git a/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
b/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
index
20d197ab8840ba5813d8e3b54420d4c3424f5a24..3ba4de4b85a6b7a31c9ce0e88df27b724fdb54d9
100644
--- a/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
+++ b/chrome/browser/chromeos/extensions/file_manager/file_tasks.cc
@@ -126,17 +126,6 @@ FullTaskDescriptor::FullTaskDescriptor(
       is_default_(is_default){
 }
 
-scoped_ptr<base::DictionaryValue>
-FullTaskDescriptor::AsDictionaryValue() const {
-  scoped_ptr<base::DictionaryValue> dictionary(new base::DictionaryValue);
-  dictionary->SetString("taskId", TaskDescriptorToId(task_descriptor_));
-  if (!icon_url_.is_empty())
-    dictionary->SetString("iconUrl", icon_url_.spec());
-  dictionary->SetString("title", task_title_);
-  dictionary->SetBoolean("isDefault", is_default_);
-  return dictionary.Pass();
-}
-
 void UpdateDefaultTask(PrefService* pref_service,
                        const std::string& task_id,
                        const std::set<std::string>& suffixes,

[commit-bot: I haz the power, 2013-09-05 03:40:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/23740004/19001

[commit-bot: I haz the power, 2013-09-05 03:47:59]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[hirono, 2013-09-05 03:51:56]

@benwells - Could you take a look the CL? Thank you!

[benwells, 2013-09-06 01:18:29]

lgtm

[commit-bot: I haz the power, 2013-09-06 01:40:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/23740004/19001

[commit-bot: I haz the power, 2013-09-06 02:21:17]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-06 03:16:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/23740004/47001

[commit-bot: I haz the power, 2013-09-06 03:54:55]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-06 04:21:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hirono@chromium.org/23740004/52001

[commit-bot: I haz the power, 2013-09-06 07:59:47]

Change committed as 221635