Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 2373983003: [inspector] added devtools-reviews@chromium.org in WATCHLISTS for inspector (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] added devtools-reviews@chromium.org in WATCHLISTS for inspector BUG=chromium:635948 R=dgozman@chromium.org,jochen@chromium.org Committed: https://crrev.com/497af7fca5dc9c807ab69a381f4e526132c41754 Cr-Commit-Position: refs/heads/master@{#39877}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M WATCHLISTS View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
kozy
Please take a look.
4 years, 2 months ago (2016-09-28 19:49:11 UTC) #3
dgozman
lgtm https://codereview.chromium.org/2373983003/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2373983003/diff/1/WATCHLISTS#newcode67 WATCHLISTS:67: 'filepath': 'src/inspector/', We also need include/v8-inspector* and test/inspector-protocol. ...
4 years, 2 months ago (2016-09-28 20:16:40 UTC) #4
kozy
all done, thanks. https://codereview.chromium.org/2373983003/diff/1/WATCHLISTS File WATCHLISTS (right): https://codereview.chromium.org/2373983003/diff/1/WATCHLISTS#newcode67 WATCHLISTS:67: 'filepath': 'src/inspector/', On 2016/09/28 20:16:40, dgozman ...
4 years, 2 months ago (2016-09-28 20:29:45 UTC) #5
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-09-29 12:08:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373983003/20001
4 years, 2 months ago (2016-09-29 14:26:35 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-29 15:16:50 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 15:17:04 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/497af7fca5dc9c807ab69a381f4e526132c41754
Cr-Commit-Position: refs/heads/master@{#39877}

Powered by Google App Engine
This is Rietveld 408576698