Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2373973002:
TRACE_EVENT_x_WITH_TIMESTAMP should log current thread id (Closed)
|
Created:
4 years, 2 months ago by Kunihiko Sakamoto Modified:
4 years, 2 months ago CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, fmeawad Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionTRACE_EVENT_x_WITH_TIMESTAMP should log current thread id
page_cycler_v2 benchmark is not working since crrev.com/2341333003
because chromium implementation of some trace macros did not set
thread id appropriately.
These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records
current thread id.
Committed: https://crrev.com/8be8fed5b085ca38259e5e5c5d9026d8198f96ea
Cr-Commit-Position: refs/heads/master@{#421714}
Patch Set 1 #
Messages
Total messages: 21 (15 generated)
The CQ bit was checked by ksakamoto@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== TRACE_EVENT_x_WITH_TIMESTAMP macros should log current thread id BUG= ========== to ========== TRACE_EVENT_x_WITH_TIMESTAMP macros should log current thread id PCv2 loading_metrics has been broken since crrev.com/2341333003 because chromium implementation of these macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ==========
Description was changed from ========== TRACE_EVENT_x_WITH_TIMESTAMP macros should log current thread id PCv2 loading_metrics has been broken since crrev.com/2341333003 because chromium implementation of these macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ========== to ========== TRACE_EVENT_x_WITH_TIMESTAMP macros should log current thread id PCv2 loading_metrics is not working since crrev.com/2341333003 because chromium implementation of these macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ==========
Description was changed from ========== TRACE_EVENT_x_WITH_TIMESTAMP macros should log current thread id PCv2 loading_metrics is not working since crrev.com/2341333003 because chromium implementation of these macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ========== to ========== TRACE_EVENT_x_WITH_TIMESTAMP macros should log current thread id page_cycler_v2 is not working since crrev.com/2341333003 because chromium implementation of these macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ==========
Description was changed from ========== TRACE_EVENT_x_WITH_TIMESTAMP macros should log current thread id page_cycler_v2 is not working since crrev.com/2341333003 because chromium implementation of these macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ========== to ========== TRACE_EVENT_x_WITH_TIMESTAMP macros should log current thread id page_cycler_v2 is not working since crrev.com/2341333003 because chromium implementation of some trace macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ==========
Description was changed from ========== TRACE_EVENT_x_WITH_TIMESTAMP macros should log current thread id page_cycler_v2 is not working since crrev.com/2341333003 because chromium implementation of some trace macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ========== to ========== TRACE_EVENT_x_WITH_TIMESTAMP macros should log current thread id page_cycler_v2 benchmark is not working since crrev.com/2341333003 because chromium implementation of some trace macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ==========
Description was changed from ========== TRACE_EVENT_x_WITH_TIMESTAMP macros should log current thread id page_cycler_v2 benchmark is not working since crrev.com/2341333003 because chromium implementation of some trace macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ========== to ========== TRACE_EVENT_x_WITH_TIMESTAMP should log current thread id page_cycler_v2 benchmark is not working since crrev.com/2341333003 because chromium implementation of some trace macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ==========
ksakamoto@chromium.org changed reviewers: + oysteine@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
eakuefner@chromium.org changed reviewers: + eakuefner@chromium.org
lgtm
The CQ bit was checked by ksakamoto@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== TRACE_EVENT_x_WITH_TIMESTAMP should log current thread id page_cycler_v2 benchmark is not working since crrev.com/2341333003 because chromium implementation of some trace macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ========== to ========== TRACE_EVENT_x_WITH_TIMESTAMP should log current thread id page_cycler_v2 benchmark is not working since crrev.com/2341333003 because chromium implementation of some trace macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== TRACE_EVENT_x_WITH_TIMESTAMP should log current thread id page_cycler_v2 benchmark is not working since crrev.com/2341333003 because chromium implementation of some trace macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. ========== to ========== TRACE_EVENT_x_WITH_TIMESTAMP should log current thread id page_cycler_v2 benchmark is not working since crrev.com/2341333003 because chromium implementation of some trace macros did not set thread id appropriately. These should use INTERNAL_TRACE_EVENT_ADD_WITH_TIMESTAMP that records current thread id. Committed: https://crrev.com/8be8fed5b085ca38259e5e5c5d9026d8198f96ea Cr-Commit-Position: refs/heads/master@{#421714} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8be8fed5b085ca38259e5e5c5d9026d8198f96ea Cr-Commit-Position: refs/heads/master@{#421714} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
