Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp

Issue 2373963002: Support display:flex for 'summary' (Closed)
Patch Set: Support flex for 'summary' Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/html/summary-display-flex-expected.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp b/third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp
index 96289cd611da91634271cf2aaec004bc3f9c3ebf..b51f0b28f0ff6189323273b6e48a1323e036efea 100644
--- a/third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSummaryElement.cpp
@@ -30,6 +30,7 @@
#include "core/html/shadow/DetailsMarkerControl.h"
#include "core/html/shadow/ShadowElementNames.h"
#include "core/layout/LayoutBlockFlow.h"
+#include "core/layout/LayoutFlexibleBox.h"
namespace blink {
@@ -47,8 +48,11 @@ HTMLSummaryElement::HTMLSummaryElement(Document& document)
{
}
-LayoutObject* HTMLSummaryElement::createLayoutObject(const ComputedStyle&)
+LayoutObject* HTMLSummaryElement::createLayoutObject(const ComputedStyle& style)
{
+ EDisplay display = style.display();
+ if (display == FLEX || display == INLINE_FLEX || display == INLINE_GRID)
cbiesinger 2016/09/28 16:51:11 Please add GRID as well
+ return LayoutObject::createObject(this, style);
return new LayoutBlockFlow(this);
}
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/html/summary-display-flex-expected.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698