Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: chrome/browser/ui/cocoa/browser_window_controller_private.mm

Issue 2373943002: Mac: Don't call -[BWC layoutSubviews] before updating the fullscreen bubble. (Closed)
Patch Set: Layout() unused Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h" 5 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
6 6
7 #include <cmath> 7 #include <cmath>
8 8
9 #import "base/auto_reset.h" 9 #import "base/auto_reset.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 996 matching lines...) Expand 10 before | Expand all | Expand 10 after
1007 if (!NSIsEmptyRect(output.fullscreenBackingBarFrame)) { 1007 if (!NSIsEmptyRect(output.fullscreenBackingBarFrame)) {
1008 [floatingBarBackingView_ setFrame:output.fullscreenBackingBarFrame]; 1008 [floatingBarBackingView_ setFrame:output.fullscreenBackingBarFrame];
1009 [fullscreenToolbarController_ 1009 [fullscreenToolbarController_
1010 setTrackingAreaFromOverlayFrame:output.fullscreenBackingBarFrame]; 1010 setTrackingAreaFromOverlayFrame:output.fullscreenBackingBarFrame];
1011 } 1011 }
1012 1012
1013 [findBarCocoaController_ 1013 [findBarCocoaController_
1014 positionFindBarViewAtMaxY:output.findBarMaxY 1014 positionFindBarViewAtMaxY:output.findBarMaxY
1015 maxWidth:NSWidth(output.contentAreaFrame)]; 1015 maxWidth:NSWidth(output.contentAreaFrame)];
1016 1016
1017 exclusiveAccessController_->Layout(output.fullscreenExitButtonMaxY);
1018
1019 if (fullscreenLowPowerCoordinator_) { 1017 if (fullscreenLowPowerCoordinator_) {
1020 fullscreenLowPowerCoordinator_->SetLayoutParameters( 1018 fullscreenLowPowerCoordinator_->SetLayoutParameters(
1021 output.toolbarFrame, output.infoBarFrame, output.contentAreaFrame, 1019 output.toolbarFrame, output.infoBarFrame, output.contentAreaFrame,
1022 output.downloadShelfFrame); 1020 output.downloadShelfFrame);
1023 } 1021 }
1024 } 1022 }
1025 1023
1026 - (void)updateSubviewZOrder { 1024 - (void)updateSubviewZOrder {
1027 if ([self isInAnyFullscreenMode]) 1025 if ([self isInAnyFullscreenMode])
1028 [self updateSubviewZOrderFullscreen]; 1026 [self updateSubviewZOrderFullscreen];
(...skipping 235 matching lines...) Expand 10 before | Expand all | Expand 10 after
1264 if (fullscreenLowPowerCoordinator_) 1262 if (fullscreenLowPowerCoordinator_)
1265 fullscreenLowPowerCoordinator_->SetHasActiveSheet(false); 1263 fullscreenLowPowerCoordinator_->SetHasActiveSheet(false);
1266 } 1264 }
1267 1265
1268 - (void)childWindowsDidChange { 1266 - (void)childWindowsDidChange {
1269 if (fullscreenLowPowerCoordinator_) 1267 if (fullscreenLowPowerCoordinator_)
1270 fullscreenLowPowerCoordinator_->ChildWindowsChanged(); 1268 fullscreenLowPowerCoordinator_->ChildWindowsChanged();
1271 } 1269 }
1272 1270
1273 @end // @implementation BrowserWindowController(Private) 1271 @end // @implementation BrowserWindowController(Private)
OLDNEW
« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_controller.mm ('k') | chrome/browser/ui/cocoa/browser_window_layout.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698