Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: components/offline_pages/offline_store_types.h

Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue (Closed)
Patch Set: Addressing final feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/background/request_queue_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_store_types.h
diff --git a/components/offline_pages/offline_store_types.h b/components/offline_pages/offline_store_types.h
index 37c701c203a163619d44cf18365414ecadb9d15f..9002c9d243f8f0406de8bbc3c054f4c802064d85 100644
--- a/components/offline_pages/offline_store_types.h
+++ b/components/offline_pages/offline_store_types.h
@@ -26,6 +26,7 @@ enum class StoreState {
};
// Statuses referring to actions taken on items in the stores.
+// GENERATED_JAVA_ENUM_PACKAGE:org.chromium.components.offlinepages
enum class ItemActionStatus {
SUCCESS,
ALREADY_EXISTS,
@@ -33,6 +34,9 @@ enum class ItemActionStatus {
STORE_ERROR,
};
+// List of item action statuses mapped to item ID.
+typedef std::vector<std::pair<int64_t, ItemActionStatus>> MultipleItemStatuses;
+
// Collective result for store update.
template <typename T>
class StoreUpdateResult {
@@ -43,7 +47,7 @@ class StoreUpdateResult {
// List of Offline ID to item action status mappings.
// It is meant to be consumed by the original caller of the operation.
- std::vector<std::pair<int64_t, ItemActionStatus>> item_statuses;
+ MultipleItemStatuses item_statuses;
// List of successfully updated offline page items as seen after operation
// concludes. It is meant to be used when passing to the observers.
« no previous file with comments | « components/offline_pages/background/request_queue_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698