Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Unified Diff: components/offline_pages/background/request_queue_store.h

Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue (Closed)
Patch Set: Addressing final feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue_store.h
diff --git a/components/offline_pages/background/request_queue_store.h b/components/offline_pages/background/request_queue_store.h
index 950f1ec8a1bcb51a8656cf301c41307af994fc5c..b661ea0faae1341c06c30b99d709ba70acb44138 100644
--- a/components/offline_pages/background/request_queue_store.h
+++ b/components/offline_pages/background/request_queue_store.h
@@ -31,10 +31,6 @@ class RequestQueueStore {
std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>
GetRequestsCallback;
typedef base::Callback<void(ItemActionStatus)> AddCallback;
- typedef base::Callback<void(
- const RequestQueue::UpdateMultipleRequestResults& /* statuses */,
- std::vector<std::unique_ptr<SavePageRequest>> /* requests */)>
- RemoveCallback;
typedef base::Callback<void(bool /* success */)> ResetCallback;
virtual ~RequestQueueStore(){};
@@ -57,7 +53,7 @@ class RequestQueueStore {
// Result of remove should be false, when one of the provided items couldn't
// be deleted, e.g. because it was missing.
virtual void RemoveRequests(const std::vector<int64_t>& request_ids,
- const RemoveCallback& callback) = 0;
+ const UpdateCallback& callback) = 0;
// Resets the store.
virtual void Reset(const ResetCallback& callback) = 0;

Powered by Google App Engine
This is Rietveld 408576698