components/offline_pages/background/request_queue_in_memory_store.h - Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_in_memory_store.h

Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue (Closed)

Patch Set: Addressing final feedback Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/offline_pages/background/request_queue.cc ('k') | components/offline_pages/background/request_queue_in_memory_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/background/request_queue_in_memory_store.h

diff --git a/components/offline_pages/background/request_queue_in_memory_store.h b/components/offline_pages/background/request_queue_in_memory_store.h

index 094f1186318e0ab5ed52ccce750f7f055a9562ca..7c8b138dcd5dfda216aca05e0043df28f20e5db8 100644

--- a/components/offline_pages/background/request_queue_in_memory_store.h

+++ b/components/offline_pages/background/request_queue_in_memory_store.h

@@ -27,12 +27,8 @@ class RequestQueueInMemoryStore : public RequestQueueStore {

const AddCallback& callback) override;

void UpdateRequests(const std::vector<SavePageRequest>& requests,

const UpdateCallback& callback) override;

- // Remove requests by request ID. The callback will get a list of

- // UpdateMultipleRequestResults and a list of the removed requests (for use by

- // notifications).

void RemoveRequests(const std::vector<int64_t>& request_ids,

- const RemoveCallback& callback) override;

+ const UpdateCallback& callback) override;

void Reset(const ResetCallback& callback) override;

StoreState state() const override;