Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1814)

Unified Diff: components/offline_pages/background/remove_requests_task.h

Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue (Closed)
Patch Set: Addressing final feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/remove_requests_task.h
diff --git a/components/offline_pages/background/remove_requests_task.h b/components/offline_pages/background/remove_requests_task.h
new file mode 100644
index 0000000000000000000000000000000000000000..a110134e7ea6c4591c43de8784320797016a7593
--- /dev/null
+++ b/components/offline_pages/background/remove_requests_task.h
@@ -0,0 +1,53 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_REMOVE_REQUESTS_TASK_H_
+#define COMPONENTS_OFFLINE_PAGES_BACKGROUND_REMOVE_REQUESTS_TASK_H_
+
+#include <stdint.h>
+
+#include <memory>
+#include <vector>
+
+#include "base/memory/weak_ptr.h"
+#include "components/offline_pages/background/request_queue_store.h"
+#include "components/offline_pages/background/save_page_request.h"
+#include "components/offline_pages/core/task.h"
+
+namespace offline_pages {
+
+class RemoveRequestsTask : public Task {
+ public:
+ RemoveRequestsTask(RequestQueueStore* store,
+ const std::vector<int64_t>& request_ids,
+ const RequestQueueStore::UpdateCallback& callback);
+ ~RemoveRequestsTask() override;
+
+ // TaskQueue::Task implementation.
+ void Run() override;
+
+ private:
+ // Step 1. Removes requests from the store.
+ void RemoveRequests();
+ // Step for early termination, that builds failure result.
+ void CompleteEarly(ItemActionStatus status);
+ // Step 2. Processes update result, calls callback.
+ void CompleteWithResult(std::unique_ptr<UpdateRequestsResult> result);
+
+ // Store that this task updates.
+ RequestQueueStore* store_;
+ // Request IDs to be updated.
+ // TODO(fgorski): perhaps convert to unique_ptr to a vector.
+ std::vector<int64_t> request_ids_;
+ // Callback to complete the task.
+ RequestQueueStore::UpdateCallback callback_;
+
+ base::WeakPtrFactory<RemoveRequestsTask> weak_ptr_factory_;
+
+ DISALLOW_COPY_AND_ASSIGN(RemoveRequestsTask);
+};
+
+} // namespace offline_pages
+
+#endif // COMPONENTS_OFFLINE_PAGES_BACKGROUND_REMOVE_REQUESTS_TASK_H_

Powered by Google App Engine
This is Rietveld 408576698