Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc

Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue (Closed)
Patch Set: Addressing final feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
diff --git a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
index bddeb65a6fa1d8cd5f68d83afe284786ba5c1bbb..5fe81fc04b2e09a54348ad9fd74fdd4a63d3db75 100644
--- a/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
+++ b/chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
@@ -48,13 +48,11 @@ std::string OfflineInternalsUIMessageHandler::GetStringFromDeletePageResult(
}
std::string OfflineInternalsUIMessageHandler::GetStringFromDeleteRequestResults(
- const offline_pages::RequestQueue::UpdateMultipleRequestResults& results) {
+ const offline_pages::MultipleItemStatuses& results) {
// If any requests failed, return "failure", else "success".
for (const auto& result : results) {
- if (result.second ==
- offline_pages::RequestQueue::UpdateRequestResult::STORE_FAILURE) {
+ if (result.second == offline_pages::ItemActionStatus::STORE_ERROR)
return "Store failure, could not delete one or more requests";
- }
}
return "Success";
@@ -124,7 +122,7 @@ void OfflineInternalsUIMessageHandler::HandleDeletedPagesCallback(
void OfflineInternalsUIMessageHandler::HandleDeletedRequestsCallback(
std::string callback_id,
- const offline_pages::RequestQueue::UpdateMultipleRequestResults& results) {
+ const offline_pages::MultipleItemStatuses& results) {
ResolveJavascriptCallback(
base::StringValue(callback_id),
base::StringValue(GetStringFromDeleteRequestResults(results)));
« no previous file with comments | « chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.h ('k') | components/offline_pages/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698