Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: components/offline_pages/background/request_coordinator_unittest.cc

Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue (Closed)
Patch Set: Rebasing Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_coordinator.h" 5 #include "components/offline_pages/background/request_coordinator.h"
6 6
7 #include <memory> 7 #include <memory>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 226
227 // Callback for Add requests. 227 // Callback for Add requests.
228 void AddRequestDone(RequestQueue::AddRequestResult result, 228 void AddRequestDone(RequestQueue::AddRequestResult result,
229 const SavePageRequest& request); 229 const SavePageRequest& request);
230 230
231 // Callback for getting requests. 231 // Callback for getting requests.
232 void GetRequestsDone(RequestQueue::GetRequestsResult result, 232 void GetRequestsDone(RequestQueue::GetRequestsResult result,
233 std::vector<std::unique_ptr<SavePageRequest>> requests); 233 std::vector<std::unique_ptr<SavePageRequest>> requests);
234 234
235 // Callback for removing requests. 235 // Callback for removing requests.
236 void RemoveRequestsDone( 236 void RemoveRequestsDone(const MultipleItemStatuses& results);
237 const RequestQueue::UpdateMultipleRequestResults& results);
238 237
239 // Callback for getting request statuses. 238 // Callback for getting request statuses.
240 void GetQueuedRequestsDone( 239 void GetQueuedRequestsDone(
241 std::vector<std::unique_ptr<SavePageRequest>> requests); 240 std::vector<std::unique_ptr<SavePageRequest>> requests);
242 241
243 void SendOfflinerDoneCallback(const SavePageRequest& request, 242 void SendOfflinerDoneCallback(const SavePageRequest& request,
244 Offliner::RequestStatus status); 243 Offliner::RequestStatus status);
245 244
246 RequestQueue::GetRequestsResult last_get_requests_result() const { 245 RequestQueue::GetRequestsResult last_get_requests_result() const {
247 return last_get_requests_result_; 246 return last_get_requests_result_;
248 } 247 }
249 248
250 const std::vector<std::unique_ptr<SavePageRequest>>& last_requests() const { 249 const std::vector<std::unique_ptr<SavePageRequest>>& last_requests() const {
251 return last_requests_; 250 return last_requests_;
252 } 251 }
253 252
254 const RequestQueue::UpdateMultipleRequestResults& last_remove_results() 253 const MultipleItemStatuses& last_remove_results() const {
255 const {
256 return last_remove_results_; 254 return last_remove_results_;
257 } 255 }
258 256
259 void EnableOfflinerCallback(bool enable) { 257 void EnableOfflinerCallback(bool enable) {
260 offliner_->enable_callback(enable); 258 offliner_->enable_callback(enable);
261 } 259 }
262 260
263 void SetNetworkConditionsForTest( 261 void SetNetworkConditionsForTest(
264 net::NetworkChangeNotifier::ConnectionType connection) { 262 net::NetworkChangeNotifier::ConnectionType connection) {
265 coordinator()->SetNetworkConditionsForTest(connection); 263 coordinator()->SetNetworkConditionsForTest(connection);
(...skipping 28 matching lines...) Expand all
294 Offliner::RequestStatus last_offlining_status() const { 292 Offliner::RequestStatus last_offlining_status() const {
295 return coordinator_->last_offlining_status_; 293 return coordinator_->last_offlining_status_;
296 } 294 }
297 295
298 bool OfflinerWasCanceled() const { return offliner_->cancel_called(); } 296 bool OfflinerWasCanceled() const { return offliner_->cancel_called(); }
299 297
300 ObserverStub observer() { return observer_; } 298 ObserverStub observer() { return observer_; }
301 299
302 private: 300 private:
303 RequestQueue::GetRequestsResult last_get_requests_result_; 301 RequestQueue::GetRequestsResult last_get_requests_result_;
304 RequestQueue::UpdateMultipleRequestResults last_remove_results_; 302 MultipleItemStatuses last_remove_results_;
305 std::vector<std::unique_ptr<SavePageRequest>> last_requests_; 303 std::vector<std::unique_ptr<SavePageRequest>> last_requests_;
306 scoped_refptr<base::TestMockTimeTaskRunner> task_runner_; 304 scoped_refptr<base::TestMockTimeTaskRunner> task_runner_;
307 base::ThreadTaskRunnerHandle task_runner_handle_; 305 base::ThreadTaskRunnerHandle task_runner_handle_;
308 std::unique_ptr<NetworkQualityEstimatorStub> network_quality_estimator_; 306 std::unique_ptr<NetworkQualityEstimatorStub> network_quality_estimator_;
309 std::unique_ptr<RequestCoordinator> coordinator_; 307 std::unique_ptr<RequestCoordinator> coordinator_;
310 OfflinerStub* offliner_; 308 OfflinerStub* offliner_;
311 base::WaitableEvent waiter_; 309 base::WaitableEvent waiter_;
312 ObserverStub observer_; 310 ObserverStub observer_;
313 }; 311 };
314 312
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
348 } 346 }
349 347
350 void RequestCoordinatorTest::GetRequestsDone( 348 void RequestCoordinatorTest::GetRequestsDone(
351 RequestQueue::GetRequestsResult result, 349 RequestQueue::GetRequestsResult result,
352 std::vector<std::unique_ptr<SavePageRequest>> requests) { 350 std::vector<std::unique_ptr<SavePageRequest>> requests) {
353 last_get_requests_result_ = result; 351 last_get_requests_result_ = result;
354 last_requests_ = std::move(requests); 352 last_requests_ = std::move(requests);
355 } 353 }
356 354
357 void RequestCoordinatorTest::RemoveRequestsDone( 355 void RequestCoordinatorTest::RemoveRequestsDone(
358 const RequestQueue::UpdateMultipleRequestResults& results) { 356 const MultipleItemStatuses& results) {
359 last_remove_results_ = results; 357 last_remove_results_ = results;
360 waiter_.Signal(); 358 waiter_.Signal();
361 } 359 }
362 360
363 void RequestCoordinatorTest::GetQueuedRequestsDone( 361 void RequestCoordinatorTest::GetQueuedRequestsDone(
364 std::vector<std::unique_ptr<SavePageRequest>> requests) { 362 std::vector<std::unique_ptr<SavePageRequest>> requests) {
365 last_requests_ = std::move(requests); 363 last_requests_ = std::move(requests);
366 waiter_.Signal(); 364 waiter_.Signal();
367 } 365 }
368 366
(...skipping 688 matching lines...) Expand 10 before | Expand all | Expand 10 after
1057 // Now whether processing triggered immediately depends on whether test 1055 // Now whether processing triggered immediately depends on whether test
1058 // is run on svelte device or not. 1056 // is run on svelte device or not.
1059 if (base::SysInfo::IsLowEndDevice()) { 1057 if (base::SysInfo::IsLowEndDevice()) {
1060 EXPECT_FALSE(is_busy()); 1058 EXPECT_FALSE(is_busy());
1061 } else { 1059 } else {
1062 EXPECT_TRUE(is_busy()); 1060 EXPECT_TRUE(is_busy());
1063 } 1061 }
1064 } 1062 }
1065 1063
1066 } // namespace offline_pages 1064 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698