Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: components/offline_pages/background/request_queue_in_memory_store.cc

Issue 2373933003: [Offline pages] Updating RequestQueue::RemoveRequests to use a TaskQueue (Closed)
Patch Set: Addressing final feedback Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_queue_in_memory_store.h" 5 #include "components/offline_pages/background/request_queue_in_memory_store.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/location.h" 8 #include "base/location.h"
9 #include "base/threading/thread_task_runner_handle.h" 9 #include "base/threading/thread_task_runner_handle.h"
10 #include "components/offline_pages/background/save_page_request.h" 10 #include "components/offline_pages/background/save_page_request.h"
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 result->item_statuses.push_back( 62 result->item_statuses.push_back(
63 std::make_pair(request.request_id(), status)); 63 std::make_pair(request.request_id(), status));
64 } 64 }
65 65
66 base::ThreadTaskRunnerHandle::Get()->PostTask( 66 base::ThreadTaskRunnerHandle::Get()->PostTask(
67 FROM_HERE, base::Bind(callback, base::Passed(&result))); 67 FROM_HERE, base::Bind(callback, base::Passed(&result)));
68 } 68 }
69 69
70 void RequestQueueInMemoryStore::RemoveRequests( 70 void RequestQueueInMemoryStore::RemoveRequests(
71 const std::vector<int64_t>& request_ids, 71 const std::vector<int64_t>& request_ids,
72 const RemoveCallback& callback) { 72 const UpdateCallback& callback) {
73 RequestQueue::UpdateMultipleRequestResults results; 73 std::unique_ptr<UpdateRequestsResult> result(
74 RequestQueue::UpdateRequestResult result; 74 new UpdateRequestsResult(StoreState::LOADED));
75 std::vector<std::unique_ptr<SavePageRequest>> requests;
76 RequestsMap::iterator iter;
77 75
76 ItemActionStatus status;
78 // If we find a request, mark it as succeeded, and put it in the request list. 77 // If we find a request, mark it as succeeded, and put it in the request list.
79 // Otherwise mark it as failed. 78 // Otherwise mark it as failed.
80 for (auto request_id : request_ids) { 79 for (auto request_id : request_ids) {
81 iter = requests_.find(request_id); 80 RequestsMap::iterator iter = requests_.find(request_id);
82 if (iter != requests_.end()) { 81 if (iter != requests_.end()) {
83 std::unique_ptr<SavePageRequest> request( 82 status = ItemActionStatus::SUCCESS;
84 new SavePageRequest(iter->second)); 83 result->updated_items.push_back(iter->second);
85 requests_.erase(iter); 84 requests_.erase(iter);
86 result = RequestQueue::UpdateRequestResult::SUCCESS;
87 requests.push_back(std::move(request));
88 } else { 85 } else {
89 result = RequestQueue::UpdateRequestResult::REQUEST_DOES_NOT_EXIST; 86 status = ItemActionStatus::NOT_FOUND;
90 } 87 }
91 results.push_back(std::make_pair(request_id, result)); 88 result->item_statuses.push_back(std::make_pair(request_id, status));
92 } 89 }
93 90
94 base::ThreadTaskRunnerHandle::Get()->PostTask( 91 base::ThreadTaskRunnerHandle::Get()->PostTask(
95 FROM_HERE, 92 FROM_HERE, base::Bind(callback, base::Passed(&result)));
96 base::Bind(callback, results, base::Passed(std::move(requests))));
97 } 93 }
98 94
99 void RequestQueueInMemoryStore::Reset(const ResetCallback& callback) { 95 void RequestQueueInMemoryStore::Reset(const ResetCallback& callback) {
100 requests_.clear(); 96 requests_.clear();
101 base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE, 97 base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
102 base::Bind(callback, true)); 98 base::Bind(callback, true));
103 } 99 }
104 100
105 StoreState RequestQueueInMemoryStore::state() const { 101 StoreState RequestQueueInMemoryStore::state() const {
106 return StoreState::LOADED; 102 return StoreState::LOADED;
107 } 103 }
108 104
109 } // namespace offline_pages 105 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698