Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 2373913004: [DevTools] Fix and rebaseline inspector/service-workers layout tests. (Closed)

Created:
4 years, 2 months ago by dgozman
Modified:
4 years, 2 months ago
Reviewers:
lushnikov
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fix and rebaseline inspector/service-workers layout tests. BUG=650965 Committed: https://crrev.com/b38356129a7206f134a1cb57c8a567b9d8c938e9 Cr-Commit-Position: refs/heads/master@{#421639}

Patch Set 1 #

Total comments: 1

Messages

Total messages: 8 (3 generated)
dgozman
Take a look please.
4 years, 2 months ago (2016-09-28 18:37:06 UTC) #2
lushnikov
lgtm https://codereview.chromium.org/2373913004/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-manager.html File third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-manager.html (right): https://codereview.chromium.org/2373913004/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-manager.html#newcode22 third_party/WebKit/LayoutTests/http/tests/inspector/service-workers/service-worker-manager.html:22: for (var version of registration.versions.valuesArray()) { nit: drop ...
4 years, 2 months ago (2016-09-28 18:46:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373913004/1
4 years, 2 months ago (2016-09-28 18:47:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 21:12:58 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 21:15:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b38356129a7206f134a1cb57c8a567b9d8c938e9
Cr-Commit-Position: refs/heads/master@{#421639}

Powered by Google App Engine
This is Rietveld 408576698