Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(589)

Issue 2373883002: Clean up PermissionContextBaseTests code. (Closed)

Created:
4 years, 2 months ago by Lei Zhang
Modified:
4 years, 2 months ago
Reviewers:
dominickn
CC:
chromium-reviews, mlamouri+watch-permissions_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up PermissionContextBaseTests code. Fix crashes when running with --single-process-tests BUG=650828 Committed: https://crrev.com/9bdf7f221dcf693eebce8c57567314e058368c36 Cr-Commit-Position: refs/heads/master@{#421404}

Patch Set 1 : cleanup #

Patch Set 2 : build #

Patch Set 3 : MakeUnique, git cl format #

Patch Set 4 : Stop using base::FeatureList::ClearInstanceForTesting() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -39 lines) Patch
M chrome/browser/permissions/permission_context_base_unittest.cc View 1 2 3 17 chunks +45 lines, -39 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Lei Zhang
4 years, 2 months ago (2016-09-27 21:59:05 UTC) #5
dominickn
lgtm, thanks!
4 years, 2 months ago (2016-09-28 00:50:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373883002/60001
4 years, 2 months ago (2016-09-28 00:50:51 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 2 months ago (2016-09-28 00:56:41 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 00:59:04 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9bdf7f221dcf693eebce8c57567314e058368c36
Cr-Commit-Position: refs/heads/master@{#421404}

Powered by Google App Engine
This is Rietveld 408576698