ash/common/system/chromeos/network/network_state_list_detailed_view.cc - Issue 2373863002: mustash: Connect ash system tray "show settings" items to chrome over mojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/common/system/chromeos/network/network_state_list_detailed_view.cc

Issue 2373863002: mustash: Connect ash system tray "show settings" items to chrome over mojo (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | ash/common/system/chromeos/supervised/tray_supervised_user.cc » ('j') | ash/common/system/chromeos/supervised/tray_supervised_user.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/common/system/chromeos/network/network_state_list_detailed_view.cc

diff --git a/ash/common/system/chromeos/network/network_state_list_detailed_view.cc b/ash/common/system/chromeos/network/network_state_list_detailed_view.cc

index bb10f282ebf7f6907aa735e6e4729fd4c72a2938..d9d9d89e645e7aa7325cb0fec516561985d95149 100644

--- a/ash/common/system/chromeos/network/network_state_list_detailed_view.cc

+++ b/ash/common/system/chromeos/network/network_state_list_detailed_view.cc

@@ -398,7 +398,7 @@ void NetworkStateListDetailedView::HandleButtonPressed(views::Button* sender,

ShowSettings();

close_bubble = true;

} else if (sender == proxy_settings_) {

- delegate->ChangeProxySettings();

+ delegate->ShowProxySettings();

close_bubble = true;

} else if (sender == other_mobile_) {

delegate->ShowOtherNetworkDialog(shill::kTypeCellular);