tools/perf/core/perf_benchmark.py - Issue 2373843002: Update fieldtrial_util To Handle Combined Fieldtrial Config Format

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/perf/core/perf_benchmark.py

Issue 2373843002: Update fieldtrial_util To Handle Combined Fieldtrial Config Format (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/perf/core/perf_benchmark.py

diff --git a/tools/perf/core/perf_benchmark.py b/tools/perf/core/perf_benchmark.py

index 4158e2d23219bf17eea478976e9230368c9bec6d..2adffbf583d63631778488f175c84934a4c7e195 100644

--- a/tools/perf/core/perf_benchmark.py

+++ b/tools/perf/core/perf_benchmark.py

@@ -59,9 +59,8 @@ class PerfBenchmark(benchmark.Benchmark):

return []

return fieldtrial_util.GenerateArgs(

- os.path.join(variations_dir,

- 'fieldtrial_testing_config_%s.json' % self._FixupTargetOS(

- possible_browser.target_os)))

+ os.path.join(variations_dir, 'fieldtrial_testing_config_.json'),

aiolos (Not reviewing) 2016/09/27 19:26:03 Have the platform-specific configs already been mi

robliao 2016/09/27 19:31:23 Yes, and I missed this usage. The migration occur

+ self._FixupTargetOS(possible_browser.target_os))

@staticmethod

def IsSvelte(possible_browser):