Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 2373833002: In the logtesting support module, fix the setting of logging level. (Closed)

Created:
4 years, 2 months ago by qyearsley
Modified:
4 years, 2 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, chromium-reviews, Dirk Pranke, wkorman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In the logtesting support module, fix the setting of logging level. Background: The logtesting.LoggingTestCase class sets up a logging handler with a particular level, and attaches it to the root logger. When messages are logged in code under tests in unit tests, the log messages bubble up to the root logger and then are handled by this attached handler. Each logger and handler throws away messages below its own logging level, and the default logging level for the root logger is logging.WARNING. Thus the handler would accept INFO messages by default, but the handler never sees those messages because the root logger throws them away. This CL just changes logtesting to set the log level of the root logger to the same level as the handler. This CL also adds a unit test for the logtesting module. BUG=650748 Committed: https://crrev.com/85f3c894a68932dd3f67b61d8adefeea92132bc3 Cr-Commit-Position: refs/heads/master@{#421356}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -0 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/logtesting.py View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/common/system/logtesting_unittest.py View 1 chunk +60 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
qyearsley
4 years, 2 months ago (2016-09-27 18:20:18 UTC) #2
jeffcarp
On 2016/09/27 at 18:20:18, qyearsley wrote: > lgtm
4 years, 2 months ago (2016-09-27 21:13:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373833002/1
4 years, 2 months ago (2016-09-27 22:04:18 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 22:10:37 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 22:13:19 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85f3c894a68932dd3f67b61d8adefeea92132bc3
Cr-Commit-Position: refs/heads/master@{#421356}

Powered by Google App Engine
This is Rietveld 408576698