BUILD.gn - Issue 2373783002: [build] Link V8 as component in static library builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Chromium Code Reviews

Unified Diff: BUILD.gn

Issue 2373783002: [build] Link V8 as component in static library builds (Closed)

Patch Set: Review Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn

index 2a198fbd78fb86a5aa940dc16bb35f704435bda5..99f700a824e23ff7459cbf92b5ab351580022ef6 100644

--- a/BUILD.gn

+++ b/BUILD.gn

@@ -2516,6 +2516,7 @@ if (is_component_build) {

":v8_base",

":v8_maybe_snapshot",

]

public_configs = [ ":external_config" ]

}

« no previous file with comments | « no previous file | build_overrides/v8.gni » ('j') | no next file with comments »