Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: chrome/browser/ui/views/location_bar/location_bar_view.h

Issue 2373773002: Fix a bug that viewed Omnibox hint when hint loses focus (Closed)
Patch Set: Fixed a bug that viewed Omnibox hint when hint loses focus Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
331 // Used to "reverse" the URL showing/hiding animations, since we use separate 331 // Used to "reverse" the URL showing/hiding animations, since we use separate
332 // animations whose curves are not true inverses of each other. Based on the 332 // animations whose curves are not true inverses of each other. Based on the
333 // current position of the omnibox, calculates what value the desired 333 // current position of the omnibox, calculates what value the desired
334 // animation (|hide_url_animation_| if |hide| is true, |show_url_animation_| 334 // animation (|hide_url_animation_| if |hide| is true, |show_url_animation_|
335 // if it's false) should be set to in order to produce the same omnibox 335 // if it's false) should be set to in order to produce the same omnibox
336 // position. This way we can stop the old animation, set the new animation to 336 // position. This way we can stop the old animation, set the new animation to
337 // this value, and start it running, and the text will appear to reverse 337 // this value, and start it running, and the text will appear to reverse
338 // directions from its current location. 338 // directions from its current location.
339 double GetValueForAnimation(bool hide) const; 339 double GetValueForAnimation(bool hide) const;
340 340
341 void UpdatedKeywordHintVisibility();
Peter Kasting 2016/10/02 19:01:37 Add comment about what this does.
342
341 // LocationBar: 343 // LocationBar:
342 void ShowFirstRunBubble() override; 344 void ShowFirstRunBubble() override;
343 GURL GetDestinationURL() const override; 345 GURL GetDestinationURL() const override;
344 WindowOpenDisposition GetWindowOpenDisposition() const override; 346 WindowOpenDisposition GetWindowOpenDisposition() const override;
345 ui::PageTransition GetPageTransition() const override; 347 ui::PageTransition GetPageTransition() const override;
346 void AcceptInput() override; 348 void AcceptInput() override;
347 void FocusSearch() override; 349 void FocusSearch() override;
348 void UpdateContentSettingsIcons() override; 350 void UpdateContentSettingsIcons() override;
349 void UpdateManagePasswordsIconAndBubble() override; 351 void UpdateManagePasswordsIconAndBubble() override;
350 void UpdateSaveCreditCardIcon() override; 352 void UpdateSaveCreditCardIcon() override;
(...skipping 12 matching lines...) Expand all
363 int PageActionVisibleCount() override; 365 int PageActionVisibleCount() override;
364 ExtensionAction* GetPageAction(size_t index) override; 366 ExtensionAction* GetPageAction(size_t index) override;
365 ExtensionAction* GetVisiblePageAction(size_t index) override; 367 ExtensionAction* GetVisiblePageAction(size_t index) override;
366 void TestPageActionPressed(size_t index) override; 368 void TestPageActionPressed(size_t index) override;
367 bool GetBookmarkStarVisibility() override; 369 bool GetBookmarkStarVisibility() override;
368 370
369 // views::View: 371 // views::View:
370 const char* GetClassName() const override; 372 const char* GetClassName() const override;
371 void OnBoundsChanged(const gfx::Rect& previous_bounds) override; 373 void OnBoundsChanged(const gfx::Rect& previous_bounds) override;
372 void OnFocus() override; 374 void OnFocus() override;
375 void OnBlur() override;
373 void OnPaint(gfx::Canvas* canvas) override; 376 void OnPaint(gfx::Canvas* canvas) override;
374 377
375 // views::DragController: 378 // views::DragController:
376 void WriteDragDataForView(View* sender, 379 void WriteDragDataForView(View* sender,
377 const gfx::Point& press_pt, 380 const gfx::Point& press_pt,
378 OSExchangeData* data) override; 381 OSExchangeData* data) override;
379 int GetDragOperationsForView(View* sender, const gfx::Point& p) override; 382 int GetDragOperationsForView(View* sender, const gfx::Point& p) override;
380 bool CanStartDragForView(View* sender, 383 bool CanStartDragForView(View* sender,
381 const gfx::Point& press_pt, 384 const gfx::Point& press_pt,
382 const gfx::Point& p) override; 385 const gfx::Point& p) override;
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
478 bool web_contents_null_at_last_refresh_; 481 bool web_contents_null_at_last_refresh_;
479 482
480 // These allow toggling the verbose security state behavior via flags. 483 // These allow toggling the verbose security state behavior via flags.
481 bool should_show_secure_state_; 484 bool should_show_secure_state_;
482 bool should_animate_secure_state_; 485 bool should_animate_secure_state_;
483 486
484 DISALLOW_COPY_AND_ASSIGN(LocationBarView); 487 DISALLOW_COPY_AND_ASSIGN(LocationBarView);
485 }; 488 };
486 489
487 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_ 490 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_BAR_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698