|
|
Description[inspector] don't truncate [[Entries]] from Runtime.getProperties
BUG=chromium:650729
R=dgozman@chromium.org
Committed: https://crrev.com/bcedfb029c992f2527db0d9d7766528e356ffe12
Cr-Commit-Position: refs/heads/master@{#39843}
Patch Set 1 #Patch Set 2 : another approach #
Total comments: 2
Patch Set 3 : addressed comments #Messages
Total messages: 27 (14 generated)
Dmitry, please take a look!
test is here: https://codereview.chromium.org/2376863002/
Dmitry, please take a look!
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Let's add a test! https://codereview.chromium.org/2373753003/diff/20001/src/inspector/v8-debugg... File src/inspector/v8-debugger.cc (right): https://codereview.chromium.org/2373753003/diff/20001/src/inspector/v8-debugg... src/inspector/v8-debugger.cc:794: CHECK(entriesValue->IsArray()); if (!array) return undefined
lgtm with a comment
all done, thanks! https://codereview.chromium.org/2373753003/diff/20001/src/inspector/v8-debugg... File src/inspector/v8-debugger.cc (right): https://codereview.chromium.org/2373753003/diff/20001/src/inspector/v8-debugg... src/inspector/v8-debugger.cc:794: CHECK(entriesValue->IsArray()); On 2016/09/28 20:21:52, dgozman wrote: > if (!array) return undefined Done.
The CQ bit was checked by kozyatinskiy@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org Link to the patchset: https://codereview.chromium.org/2373753003/#ps40001 (title: "addressed comments")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
kozyatinskiy@chromium.org changed reviewers: + alph@chromium.org
Alexey, please take a look, I need committer lgtm.
The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by kozyatinskiy@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== [inspector] don't truncate [[Entries]] from Runtime.getProperties BUG=chromium:650729 R=dgozman@chromium.org ========== to ========== [inspector] don't truncate [[Entries]] from Runtime.getProperties BUG=chromium:650729 R=dgozman@chromium.org Committed: https://crrev.com/bcedfb029c992f2527db0d9d7766528e356ffe12 Cr-Commit-Position: refs/heads/master@{#39843} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/bcedfb029c992f2527db0d9d7766528e356ffe12 Cr-Commit-Position: refs/heads/master@{#39843} |