Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2373753003: [inspector] don't truncate [[Entries]] from Runtime.getProperties (Closed)

Created:
4 years, 2 months ago by kozy
Modified:
4 years, 2 months ago
Reviewers:
dgozman, alph
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] don't truncate [[Entries]] from Runtime.getProperties BUG=chromium:650729 R=dgozman@chromium.org Committed: https://crrev.com/bcedfb029c992f2527db0d9d7766528e356ffe12 Cr-Commit-Position: refs/heads/master@{#39843}

Patch Set 1 #

Patch Set 2 : another approach #

Total comments: 2

Patch Set 3 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -7 lines) Patch
M src/inspector/v8-debugger.cc View 1 2 1 chunk +21 lines, -7 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
kozy
Dmitry, please take a look!
4 years, 2 months ago (2016-09-27 23:27:12 UTC) #1
kozy
test is here: https://codereview.chromium.org/2376863002/
4 years, 2 months ago (2016-09-27 23:28:02 UTC) #2
kozy
Dmitry, please take a look!
4 years, 2 months ago (2016-09-28 19:33:29 UTC) #3
dgozman
Let's add a test! https://codereview.chromium.org/2373753003/diff/20001/src/inspector/v8-debugger.cc File src/inspector/v8-debugger.cc (right): https://codereview.chromium.org/2373753003/diff/20001/src/inspector/v8-debugger.cc#newcode794 src/inspector/v8-debugger.cc:794: CHECK(entriesValue->IsArray()); if (!array) return undefined
4 years, 2 months ago (2016-09-28 20:21:52 UTC) #8
dgozman
lgtm with a comment
4 years, 2 months ago (2016-09-28 20:22:14 UTC) #9
kozy
all done, thanks! https://codereview.chromium.org/2373753003/diff/20001/src/inspector/v8-debugger.cc File src/inspector/v8-debugger.cc (right): https://codereview.chromium.org/2373753003/diff/20001/src/inspector/v8-debugger.cc#newcode794 src/inspector/v8-debugger.cc:794: CHECK(entriesValue->IsArray()); On 2016/09/28 20:21:52, dgozman wrote: ...
4 years, 2 months ago (2016-09-28 20:32:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373753003/40001
4 years, 2 months ago (2016-09-28 20:32:48 UTC) #13
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-09-28 20:32:50 UTC) #15
kozy
Alexey, please take a look, I need committer lgtm.
4 years, 2 months ago (2016-09-28 20:43:49 UTC) #17
alph
lgtm
4 years, 2 months ago (2016-09-29 00:03:34 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373753003/40001
4 years, 2 months ago (2016-09-29 00:07:20 UTC) #24
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-09-29 00:09:45 UTC) #25
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 00:10:21 UTC) #27
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bcedfb029c992f2527db0d9d7766528e356ffe12
Cr-Commit-Position: refs/heads/master@{#39843}

Powered by Google App Engine
This is Rietveld 408576698