Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 2373743002: [build] Use shared libraries by default for debug builds (Closed)

Created:
4 years, 2 months ago by Michael Achenbach
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[build] Use shared libraries by default for debug builds BUG=chromium:648864 Committed: https://crrev.com/f72b4a084af38e767acfe7470dbd93fb06281000 Cr-Commit-Position: refs/heads/master@{#39754}

Patch Set 1 #

Patch Set 2 : Add export #

Patch Set 3 : include #

Patch Set 4 : updates #

Patch Set 5 : updates + format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M infra/mb/mb_config.pyl View 2 chunks +2 lines, -4 lines 0 comments Download
M src/checks.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M src/handles.h View 1 2 3 4 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
Michael Achenbach
PTAL
4 years, 2 months ago (2016-09-27 06:45:19 UTC) #3
jgruber
lgtm
4 years, 2 months ago (2016-09-27 06:46:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373743002/1
4 years, 2 months ago (2016-09-27 06:47:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/25125)
4 years, 2 months ago (2016-09-27 06:53:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373743002/80001
4 years, 2 months ago (2016-09-27 09:18:49 UTC) #14
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 2 months ago (2016-09-27 09:46:27 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 09:46:46 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f72b4a084af38e767acfe7470dbd93fb06281000
Cr-Commit-Position: refs/heads/master@{#39754}

Powered by Google App Engine
This is Rietveld 408576698