Fix style issues with MD accessibility page

chrome/browser/resources/settings/settings_shared_css.html

 <link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">
 <link rel="import" href="/settings_vars_css.html">
 
 <!-- Common styles for Material Design settings. -->
 <dom-module id="settings-shared">
   <template>
     <style include="cr-shared-style">
       /* Use <h2> as the "sub-header" mentioned in the UX design docs. */
       h2 {
         align-items: center;
@@ skipping 84 matching lines @@
 
       span ~ a {
         -webkit-margin-start: 4px;
       }
 
       [is='action-link'],
       [is='action-link']:active,
       [is='action-link']:hover,
       [is='action-link']:visited,
       .primary-button,
-      .tertiary-button {
+      .tertiary-button,
+      a[href] {
         color: var(--google-blue-700);
       }
 
+      a[href] {
+        text-decoration: none;
+      }
+
       .primary-button,
       .tertiary-button {
         --paper-button-flat-keyboard-focus: {
           background: rgba(51, 103, 214, .12);  /* --google-blue-700 */
         };
       }
 

[Dan Beam, 2016/09/28 20:28:55]

can we combine the text-decoration rule with this one?

:-webkit-any(a[href], [is='action-link']):hover {
  text-decoration: none;
}

[dmazzoni, 2016/09/28 22:11:43]

Sure.

I combined it slightly differently so as not to break
anything else, please follow-up if that's not what you
had in mind.

:-webkit-any(a[href], [is='action-link']:hover) {

[Dan Beam, 2016/09/28 22:15:08]

well, that's fine, but it's equivalent to

a[href],
[is='action-link']:hover {
  /* ... */
}

which is more common.  :-webkit-any() is really only helpful as a prefixing
selector (i.e. any(thing1, thing2) more stuff {...})

[dmazzoni, 2016/09/28 22:29:43]

Oh, of course. Fixed.

Your suggestion would have only removed the underline on hover,
which isn't what I wanted - and I didn't want to remove
the underline from all action-links in this change.

       [is='action-link']:hover {
         text-decoration: none;
       }
 
       /* There are three main button styles, .primary-button, .secondary-button,
        * and .tertiary-button. The primary is the action button (e.g. "edit",
        * "delete") while the secondary is often a "Cancel" button. A tertiary
        * button may be used to get more information or similar, that we expect
        * most users will not need. */
       .primary-button {
@@ skipping 258 matching lines @@
       /* Turns the arrow direction downwards, when the bubble is placed above
        * the anchor element */
       .search-bubble-innards.above::after {
         -webkit-transform: rotate(-135deg);
         bottom: -5px;
         top: auto;
       }
     </style>
   </template>
 </dom-module>