Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Unified Diff: chrome/browser/android/webapk/webapk_installer.h

Issue 2373713003: Retry WebAPK download if fails for the first time. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_installer.h
diff --git a/chrome/browser/android/webapk/webapk_installer.h b/chrome/browser/android/webapk/webapk_installer.h
index eb24f5b2ce428e14f5fb30f19b64f6a1de3fc09b..767002dec666f878e350c326341351263b04b1ac 100644
--- a/chrome/browser/android/webapk/webapk_installer.h
+++ b/chrome/browser/android/webapk/webapk_installer.h
@@ -149,10 +149,18 @@ class WebApkInstaller : public net::URLFetcherDelegate {
void OnGotWebApkDownloadUrl(const GURL& download_url,
const std::string& package_name);
+ // Downloads the WebAPK from the given |donwload_url|.
pkotwicz 2016/09/27 19:47:28 Nit: |donwload_url| -> |download_url|.
Xi Han 2016/09/27 20:53:31 Done.
+ void StartDownloadingWebApk(const base::FilePath& output_path,
+ const GURL& download_url,
+ bool retry_if_fails);
+
// Called once the WebAPK has been downloaded. Makes the downloaded WebAPK
// world readable and installs the WebAPK if the download was successful.
// |file_path| is the file path that the WebAPK was downloaded to.
+ // If |retry_if_fails| is true, will sleep 2 seconds and retry the download.
pkotwicz 2016/09/27 19:47:28 You should post a delayed task instead of sleeping
Xi Han 2016/09/27 20:53:31 Done.
void OnWebApkDownloaded(const base::FilePath& file_path,
+ const GURL& download_url,
+ bool retry_if_fails,
FileDownloader::Result result);
// Called once the downloaded WebAPK has been made world readable. Installs
« no previous file with comments | « no previous file | chrome/browser/android/webapk/webapk_installer.cc » ('j') | chrome/browser/android/webapk/webapk_installer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698