Retry WebAPK download if fails for the first time.

chrome/browser/android/webapk/webapk_installer.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/webapk/webapk_installer.h"
 
 #include "base/android/build_info.h"
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/android/path_utils.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/memory/ref_counted.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/task_runner_util.h"
+#include "base/threading/platform_thread.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "chrome/browser/android/shortcut_helper.h"
 #include "chrome/browser/android/webapk/webapk.pb.h"
 #include "chrome/browser/android/webapk/webapk_icon_hasher.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_switches.h"
 #include "components/version_info/version_info.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/common/manifest_util.h"
 #include "jni/WebApkInstaller_jni.h"
@@ skipping 318 matching lines @@
 
 void WebApkInstaller::OnGotWebApkDownloadUrl(const GURL& download_url,
                                              const std::string& package_name) {
   base::FilePath output_dir;
   base::android::GetCacheDirectory(&output_dir);
   webapk_package_ = package_name;
   // TODO(pkotwicz): Download WebAPKs into WebAPK-specific subdirectory
   // directory.
   // TODO(pkotwicz): Figure out when downloaded WebAPK should be deleted.
 
+  StartDownloadingWebApk(
+      output_dir.AppendASCII(webapk_package_), download_url, true);
+}
+
+void WebApkInstaller::StartDownloadingWebApk(const base::FilePath& output_path,

[pkotwicz, 2016/09/27 19:47:28]

Nit: Rename this function to DownloadWebApk()

I think that this function name is more consistent with OnWebApkDownloaded() ...
and your comment in the .h file

[Xi Han, 2016/09/27 20:53:31]

Done.

+                                             const GURL& download_url,
+                                             bool retry_if_fails) {
   timer_.Start(
       FROM_HERE, base::TimeDelta::FromMilliseconds(download_timeout_ms_),
       base::Bind(&WebApkInstaller::OnTimeout, weak_ptr_factory_.GetWeakPtr()));
 
-  base::FilePath output_path = output_dir.AppendASCII(webapk_package_);
   downloader_.reset(new FileDownloader(
       download_url, output_path, true, request_context_getter_,
       base::Bind(&WebApkInstaller::OnWebApkDownloaded,
-                 weak_ptr_factory_.GetWeakPtr(), output_path)));
+                 weak_ptr_factory_.GetWeakPtr(),
+                 output_path, download_url, retry_if_fails)));
 }
 
 void WebApkInstaller::OnWebApkDownloaded(const base::FilePath& file_path,
+                                         const GURL& download_url,
+                                         bool retry_if_fails,
                                          FileDownloader::Result result) {
   timer_.Stop();

[pkotwicz, 2016/09/27 19:47:28]

Nit: Maybe reset |downloader_| for clarity

[Xi Han, 2016/09/27 20:53:31]

Done.

 
   if (result != FileDownloader::DOWNLOADED) {
-    OnFailure();
+    if (!retry_if_fails) {
+      OnFailure();
+      return;
+    }
+
+    base::PlatformThread::Sleep(base::TimeDelta::FromSeconds(2));

[pkotwicz, 2016/09/27 19:47:28]

Use BrowserThread::PostDelayedTask() instead

[Xi Han, 2016/09/27 20:53:31]

Done.

+    StartDownloadingWebApk(file_path, download_url, false);
     return;
   }
 
   int posix_permissions = base::FILE_PERMISSION_READ_BY_USER |
                           base::FILE_PERMISSION_WRITE_BY_USER |
                           base::FILE_PERMISSION_READ_BY_GROUP |
                           base::FILE_PERMISSION_READ_BY_OTHERS;
   base::PostTaskAndReplyWithResult(
       GetBackgroundTaskRunner().get(), FROM_HERE,
       base::Bind(&base::SetPosixFilePermissions, file_path, posix_permissions),
@@ skipping 40 matching lines @@
   std::string webapk_package = webapk_package_;
   delete this;
   callback.Run(true, webapk_package);
 }
 
 void WebApkInstaller::OnFailure() {
   FinishCallback callback = finish_callback_;
   delete this;
   callback.Run(false, "");
 }