Issue 23737005: [Files.app] Support 'newwindow' event from the CWS widget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23737005: [Files.app] Support 'newwindow' event from the CWS widget (Closed)

Created:
7 years, 3 months ago by yoshiki

Modified:
7 years, 3 months ago

Reviewers:
hirono

CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Files.app] Support 'newwindow' event from the CWS widget Suggest app dialog have to support 'newwindow' event from the CWS widget, as well as share dialog. BUG=none TEST=manual R=hirono@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=220517

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Patch Set 3 : addressed comment #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/resources/file_manager/js/suggest_apps_dialog.js	View	1 2	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

hirono

lgtm with nit! https://codereview.chromium.org/23737005/diff/1/chrome/browser/resources/file_manager/js/suggest_apps_dialog.js File chrome/browser/resources/file_manager/js/suggest_apps_dialog.js (right): https://codereview.chromium.org/23737005/diff/1/chrome/browser/resources/file_manager/js/suggest_apps_dialog.js#newcode225 chrome/browser/resources/file_manager/js/suggest_apps_dialog.js:225: webView.addEventListener('newwindow', function(e) { e -> event ...

7 years, 3 months ago (2013-08-30 02:02:36 UTC) #2

yoshiki

7 years, 3 months ago (2013-08-30 06:38:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r220517 (presubmit successful).

Expand Messages | Collapse Messages