Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Unified Diff: third_party/WebKit/Source/build/scripts/scripts.gni

Issue 2373683003: Remove som GYP annotations, remove unused manifest. (Closed)
Patch Set: Fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/android/reporter/BUILD.gn ('k') | third_party/isimpledom/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/build/scripts/scripts.gni
diff --git a/third_party/WebKit/Source/build/scripts/scripts.gni b/third_party/WebKit/Source/build/scripts/scripts.gni
index 5856751121b5808dd869b7f6a7b73af1e0e70aaf..d1c1291987f42d0465ef6ef072b191f53e31be7a 100644
--- a/third_party/WebKit/Source/build/scripts/scripts.gni
+++ b/third_party/WebKit/Source/build/scripts/scripts.gni
@@ -73,11 +73,6 @@ if (host_os == "win") {
_blink_gen_dir = "$root_gen_dir/blink"
-# The GYP target make_core_generated has some deps and a bunch of actions on
-# it, which means that the deps will be resolved before the actions run. Here
-# we have separate targets for each action. Its not clear which actions depend
-# on these deps, so for GYP compatibility, all of the below actions should
-# depend on the following deps.
make_core_generated_deps = [
"//third_party/WebKit/Source/core:generated_testing_idls",
"//third_party/WebKit/Source/core:core_event_interfaces",
@@ -89,8 +84,7 @@ make_core_generated_deps = [
# other_inputs: (optional) other input files the script depends on
# defaults to "scripts_for_in_files" (if specified, we assume
# that the contents of "scripts_for_in_files" are included in
-# this list specified since this is how these lists are filled
-# from the GYP build.
+# this list).
# outputs: expected results. Note that the directory of the 0th item in this
# list will be taken to be the output path.
# other_args: (optional) other arguments to pass to the script.
« no previous file with comments | « testing/android/reporter/BUILD.gn ('k') | third_party/isimpledom/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698