Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 2373683002: [stubs] KeyedLoadIC_Megamorphic: use stub cache lookup as fallback (Closed)

Created:
4 years, 2 months ago by Jakob Kummerow
Modified:
4 years, 2 months ago
Reviewers:
Igor Sheludko
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] KeyedLoadIC_Megamorphic: use stub cache lookup as fallback When the inline lookup on a fast-property receiver doesn't find anything, try a stub cache lookup before going into the runtime. This is much faster for properties loaded from the receiver's prototype chain. BUG=chromium:650236 Committed: https://crrev.com/b15dd963a359b8cff201d4c8e6f1ca3de7383c2b Cr-Commit-Position: refs/heads/master@{#39813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M src/code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/ic.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Jakob Kummerow
PTAL. This should repair the regression on test/js-perf-tests/Iterators/ForOf. Of course, we can consider doing inline ...
4 years, 2 months ago (2016-09-26 22:18:03 UTC) #2
Igor Sheludko
lgtm
4 years, 2 months ago (2016-09-27 06:50:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373683002/1
4 years, 2 months ago (2016-09-28 08:40:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 09:05:06 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 09:05:29 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b15dd963a359b8cff201d4c8e6f1ca3de7383c2b
Cr-Commit-Position: refs/heads/master@{#39813}

Powered by Google App Engine
This is Rietveld 408576698