Unify enum NextProto and enum AlternateProtocol.

Unify enum NextProto and enum AlternateProtocol.

* Use NextProto instead of AlternateProtocol everywhere.
* Remove enum AlternateProtocol, AlternateProtocolFromNextProto().
* Move SSLClientSocketImpl::NextProto{To,From}String() to
* next_proto.cc.
* Combine AlternateProtocol{To,From}String() into
* NextProto{To,From}String().
* Remove unused SpdyHttpStream::negotiated_protocol_.

BUG=116575
Committed: https://crrev.com/f98f01d87fb1f315de400c6829ad467ae95caa7a
Cr-Commit-Position: refs/heads/master@{#431572}

[Bence, 2016-09-26 19:27:55]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 19:28:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 19:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 19:44:48]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Bence, 2016-09-26 20:24:58]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 20:25:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 21:24:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 21:24:30]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Bence, 2016-11-10 18:41:31]

Description was changed from

==========
Unify enum NextProto and enum AlternateProtocol.

BUG=116575
==========

to

==========
Unify enum NextProto and enum AlternateProtocol.

* Use NextProto instead of AlternateProtocol everywhere.
* Remove enum AlternateProtocol, AlternateProtocolFromNextProto().
* Move SSLClientSocketImpl::NextProto{To,From}String() to
* next_proto.cc.
* Combine AlternateProtocol{To,From}String() into
* NextProto{To,From}String().
* Remove unused SpdyHttpStream::negotiated_protocol_.

BUG=116575
==========

[Bence, 2016-11-10 18:41:52]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 18:42:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 18:59:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 18:59:13]

Dry run: Try jobs failed on following builders:
  chromeos_x86-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_x86-ge...)

[Bence, 2016-11-10 20:32:46]

The CQ bit was checked by bnc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-10 20:33:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-10 21:35:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-10 21:35:34]

Dry run: This issue passed the CQ dry run.

[Bence, 2016-11-11 00:38:54]

bnc@chromium.org changed reviewers:
+ rch@chromium.org

[Bence, 2016-11-11 00:38:55]

Ryan: PTAL.  Thank you.

[Ryan Hamilton, 2016-11-11 01:19:32]

lgtm

[Bence, 2016-11-11 01:44:54]

bnc@chromium.org changed reviewers:
+ xunjieli@chromium.org

[Bence, 2016-11-11 01:44:55]

xunjieli: PTAL.  Thank you.

[xunjieli, 2016-11-11 15:10:13]

On 2016/11/11 01:44:55, Bence wrote:
> xunjieli: PTAL.  Thank you.

cronet lgtm. 
Out of paranoia, I kicked off a run off "android_cronet_tester" which is trybot
that runs all Cronet tests. 
"android_cronet" is a compile-only CQ bot.

Compilation should be sufficient for this change, but I just to make sure there
isn't anything else :)
Please wait for "android_cronet_tester" to turn green.

[Bence, 2016-11-11 16:16:03]

The CQ bit was checked by bnc@chromium.org

[commit-bot: I haz the power, 2016-11-11 16:16:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-11 16:21:43]

Description was changed from

==========
Unify enum NextProto and enum AlternateProtocol.

* Use NextProto instead of AlternateProtocol everywhere.
* Remove enum AlternateProtocol, AlternateProtocolFromNextProto().
* Move SSLClientSocketImpl::NextProto{To,From}String() to
* next_proto.cc.
* Combine AlternateProtocol{To,From}String() into
* NextProto{To,From}String().
* Remove unused SpdyHttpStream::negotiated_protocol_.

BUG=116575
==========

to

==========
Unify enum NextProto and enum AlternateProtocol.

* Use NextProto instead of AlternateProtocol everywhere.
* Remove enum AlternateProtocol, AlternateProtocolFromNextProto().
* Move SSLClientSocketImpl::NextProto{To,From}String() to
* next_proto.cc.
* Combine AlternateProtocol{To,From}String() into
* NextProto{To,From}String().
* Remove unused SpdyHttpStream::negotiated_protocol_.

BUG=116575
==========

[commit-bot: I haz the power, 2016-11-11 16:21:45]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-11 16:23:57]

Description was changed from

==========
Unify enum NextProto and enum AlternateProtocol.

* Use NextProto instead of AlternateProtocol everywhere.
* Remove enum AlternateProtocol, AlternateProtocolFromNextProto().
* Move SSLClientSocketImpl::NextProto{To,From}String() to
* next_proto.cc.
* Combine AlternateProtocol{To,From}String() into
* NextProto{To,From}String().
* Remove unused SpdyHttpStream::negotiated_protocol_.

BUG=116575
==========

to

==========
Unify enum NextProto and enum AlternateProtocol.

* Use NextProto instead of AlternateProtocol everywhere.
* Remove enum AlternateProtocol, AlternateProtocolFromNextProto().
* Move SSLClientSocketImpl::NextProto{To,From}String() to
* next_proto.cc.
* Combine AlternateProtocol{To,From}String() into
* NextProto{To,From}String().
* Remove unused SpdyHttpStream::negotiated_protocol_.

BUG=116575

Committed: https://crrev.com/f98f01d87fb1f315de400c6829ad467ae95caa7a
Cr-Commit-Position: refs/heads/master@{#431572}
==========

[commit-bot: I haz the power, 2016-11-11 16:23:58]

Patchset 4 (id:??) landed as
https://crrev.com/f98f01d87fb1f315de400c6829ad467ae95caa7a
Cr-Commit-Position: refs/heads/master@{#431572}

[Bence, 2016-11-11 16:35:39]

Thank you both for reviewing.

[Bence, 2016-11-11 16:37:00]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2496953002/ by bnc@chromium.org.

The reason for reverting is:
https://build.chromium.org/p/chromium.memory.full/builders/Chromium%20Linux%2...

../../components/grpc_support/test/get_stream_engine.cc:52:56: error: no member
named 'AlternateProtocol' in namespace 'net'; did you mean
'AlternateProtocolUsage'?
      net::AlternativeService alternative_service(net::AlternateProtocol::QUIC,
                                                  ~~~~~^~~~~~~~~~~~~~~~~
                                                       AlternateProtocolUsage
.

[findit-for-me, 2016-11-11 16:55:31]

FYI: Findit identified this CL at revision 431572 as the culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[Ryan Hamilton, 2016-11-11 18:16:44]

On 2016/11/11 16:55:31, findit-for-me wrote:
> FYI: Findit identified this CL at revision 431572 as the culprit for
> failures in the build cycles as shown on:
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

This CL landed via the CQ. Why was this build breakage not caught by the CQ?

[mmenke, 2016-11-11 18:18:39]

On 2016/11/11 18:16:44, Ryan Hamilton wrote:
> On 2016/11/11 16:55:31, findit-for-me wrote:
> > FYI: Findit identified this CL at revision 431572 as the culprit for
> > failures in the build cycles as shown on:
> >
>
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...
> 
> This CL landed via the CQ. Why was this build breakage not caught by the CQ?

I filed https://bugs.chromium.org/p/chromium/issues/detail?id=664538#c2 about
it.