Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 2373653002: [TabManager] Enable tab discarding by default. (Closed)

Created:
4 years, 2 months ago by Georges Khalil
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[TabManager] Enable tab discarding by default. This CL enables tab discarding by default and keeps the existing feature only as a kill switch. BUG=551995 Committed: https://crrev.com/ea47d44c60a7c40aec90e6d9b342c131fce23834 Cr-Commit-Position: refs/heads/master@{#421178}

Patch Set 1 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -14 lines) Patch
M chrome/browser/memory/tab_manager.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/memory/tab_manager_browsertest.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M chrome/browser/memory/tab_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_features.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (15 generated)
Georges Khalil
PTAL.
4 years, 2 months ago (2016-09-26 20:40:02 UTC) #7
Alexei Svitkine (slow)
lgtm
4 years, 2 months ago (2016-09-26 20:42:16 UTC) #9
Georges Khalil
chrisha@, PTAL.
4 years, 2 months ago (2016-09-26 20:48:21 UTC) #11
chrisha
lgtm
4 years, 2 months ago (2016-09-26 20:51:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373653002/20001
4 years, 2 months ago (2016-09-27 12:09:57 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-09-27 12:15:05 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 12:16:46 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea47d44c60a7c40aec90e6d9b342c131fce23834
Cr-Commit-Position: refs/heads/master@{#421178}

Powered by Google App Engine
This is Rietveld 408576698