Improve ergonomics of CanvasImageSource -> gfx::ImageSkia.

Improve ergonomics of CanvasImageSource -> gfx::ImageSkia.

So we don't have to write things like:
  auto source = new MySource;
  ... = gfx::ImageSkia(source, source->size());

instead, we write
  ... = CanvasImageSource::MakeImageSkia<MySource>();

BUG=none

Committed: https://crrev.com/96307adee9e24f088e57a5a12485e6caafdb8afb
Cr-Commit-Position: refs/heads/master@{#421538}

[Evan Stade, 2016-09-26 18:49:21]

estade@chromium.org changed reviewers:
+ rsesek@chromium.org

[Evan Stade, 2016-09-26 18:49:21]

wdyt? This is an alternative to adding another ctor to ImageSkia. Seems like
better dependency layering this way.

[Robert Sesek, 2016-09-26 21:59:52]

rsesek@chromium.org changed reviewers:
+ oshima@chromium.org

[Robert Sesek, 2016-09-26 21:59:53]

Seems like a nice solution to me. But +oshmia for image_skia OWNERS too.

https://codereview.chromium.org/2373633002/diff/1/ui/gfx/image/canvas_image_s...
File ui/gfx/image/canvas_image_source.h (right):

https://codereview.chromium.org/2373633002/diff/1/ui/gfx/image/canvas_image_s...
ui/gfx/image/canvas_image_source.h:26: template <typename T, typename... Args>
Should have a comment here.

https://codereview.chromium.org/2373633002/diff/1/ui/gfx/image/canvas_image_s...
ui/gfx/image/canvas_image_source.h:33: ~CanvasImageSource() override {}
Place the dtor after the ctor.

[oshima, 2016-09-27 22:50:26]

nice.

lgtm with rsesek@'s comment is addressed.

https://codereview.chromium.org/2373633002/diff/1/ui/gfx/image/canvas_image_s...
File ui/gfx/image/canvas_image_source.h (right):

https://codereview.chromium.org/2373633002/diff/1/ui/gfx/image/canvas_image_s...
ui/gfx/image/canvas_image_source.h:29: gfx::Size size = source->size();
why not just do this inline below?

[Evan Stade, 2016-09-28 01:52:34]

https://codereview.chromium.org/2373633002/diff/1/ui/gfx/image/canvas_image_s...
File ui/gfx/image/canvas_image_source.h (right):

https://codereview.chromium.org/2373633002/diff/1/ui/gfx/image/canvas_image_s...
ui/gfx/image/canvas_image_source.h:26: template <typename T, typename... Args>
On 2016/09/26 21:59:53, Robert Sesek wrote:
> Should have a comment here.

Done.

https://codereview.chromium.org/2373633002/diff/1/ui/gfx/image/canvas_image_s...
ui/gfx/image/canvas_image_source.h:29: gfx::Size size = source->size();
On 2016/09/27 22:50:26, oshima wrote:
> why not just do this inline below?
> 
>  

source.release() invalidates source and we don't know what order the arguments
will be evaluated in.

https://codereview.chromium.org/2373633002/diff/1/ui/gfx/image/canvas_image_s...
ui/gfx/image/canvas_image_source.h:33: ~CanvasImageSource() override {}
On 2016/09/26 21:59:53, Robert Sesek wrote:
> Place the dtor after the ctor.

Done.

[Evan Stade, 2016-09-28 01:52:51]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 01:53:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 04:24:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 04:24:36]

Dry run: This issue passed the CQ dry run.

[Robert Sesek, 2016-09-28 16:28:37]

lgtm

[Evan Stade, 2016-09-28 16:29:38]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2016-09-28 16:29:39]

The patchset sent to the CQ was uploaded after l-g-t-m from oshima@chromium.org
Link to the patchset: https://codereview.chromium.org/2373633002/#ps20001
(title: "review comments")

[commit-bot: I haz the power, 2016-09-28 16:29:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 16:38:35]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 16:42:05]

Description was changed from

==========
Improve ergonomics of CanvasImageSource -> gfx::ImageSkia.

So we don't have to write things like:
  auto source = new MySource;
  ... = gfx::ImageSkia(source, source->size());

instead, we write
  ... = CanvasImageSource::MakeImageSkia<MySource>();

BUG=none
==========

to

==========
Improve ergonomics of CanvasImageSource -> gfx::ImageSkia.

So we don't have to write things like:
  auto source = new MySource;
  ... = gfx::ImageSkia(source, source->size());

instead, we write
  ... = CanvasImageSource::MakeImageSkia<MySource>();

BUG=none

Committed: https://crrev.com/96307adee9e24f088e57a5a12485e6caafdb8afb
Cr-Commit-Position: refs/heads/master@{#421538}
==========

[commit-bot: I haz the power, 2016-09-28 16:42:07]

Patchset 2 (id:??) landed as
https://crrev.com/96307adee9e24f088e57a5a12485e6caafdb8afb
Cr-Commit-Position: refs/heads/master@{#421538}