Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(517)

Issue 2373613005: Update DCHECK in WebRange constructor. (Closed)

Created:
4 years, 2 months ago by mharanczyk
Modified:
4 years, 2 months ago
Reviewers:
dglazkov
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update DCHECK in WebRange constructor. Currently creating empty range (0,0) triggers it, judging by the comment it was intende to check null range only. Committed: https://crrev.com/aa8d0ff140941ba9e830090421600f47e278dcb5 Cr-Commit-Position: refs/heads/master@{#421252}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/web/WebRange.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
mharanczyk
PTAL.
4 years, 2 months ago (2016-09-27 12:59:17 UTC) #4
dglazkov
lgtm
4 years, 2 months ago (2016-09-27 16:13:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373613005/1
4 years, 2 months ago (2016-09-27 16:14:10 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 17:34:11 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/aa8d0ff140941ba9e830090421600f47e278dcb5 Cr-Commit-Position: refs/heads/master@{#421252}
4 years, 2 months ago (2016-09-27 17:36:46 UTC) #11
dglazkov
On 2016/09/27 at 12:59:17, mharanczyk wrote: > PTAL. Didn't want to block landing this patch, ...
4 years, 2 months ago (2016-09-27 17:44:24 UTC) #12
mharanczyk
4 years, 2 months ago (2016-09-28 13:07:33 UTC) #13
Message was sent while issue was closed.
On 2016/09/27 17:44:24, dglazkov wrote:
> On 2016/09/27 at 12:59:17, mharanczyk wrote:
> > PTAL.
> 
> Didn't want to block landing this patch, but could you add a unit test that
> captures this?

Thank you for allowing it to land. I will add test soon, just please give me a
day or two.

Powered by Google App Engine
This is Rietveld 408576698