md-settings: add routing to chrome://settings/resetProfileSettings.

md-settings: add routing to chrome://settings/resetProfileSettings.

BUG=636408
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e8bfb7bfdf794c8f2995bd9b0da7db2f54618aca
Cr-Commit-Position: refs/heads/master@{#421317}

[alito, 2016-09-26 23:40:20]

Description was changed from

==========
Adds md-settings routing to chrome://settings/resetProfileSettings.

BUG=636408
==========

to

==========
Adds md-settings routing to chrome://settings/resetProfileSettings.

BUG=636408
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[alito, 2016-09-26 23:42:40]

Description was changed from

==========
Adds md-settings routing to chrome://settings/resetProfileSettings.

BUG=636408
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
md-settings: add routing to chrome://settings/resetProfileSettings.

BUG=636408
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[alito, 2016-09-26 23:44:13]

alito@chromium.org changed reviewers:
+ dbeam@chromium.org

[alito, 2016-09-26 23:44:14]

PTAL.

This adds routing to the reset profile settings dialog when md-settings is
enabled.

[Dan Beam, 2016-09-27 00:31:48]

dbeam@chromium.org changed reviewers:
+ tommycli@chromium.org
- dbeam@chromium.org

[Dan Beam, 2016-09-27 00:31:49]

+tommycli@ for routing review

/cc dpapad@ cuz reset profile related

[tommycli, 2016-09-27 16:08:41]

lgtm routing issues. Looks like you modeled the implementation on the clear
browsing data dialog right? And I assume you've manually tested also?

[alito, 2016-09-27 18:32:35]

Thanks Tommy. Yes, I've tested manually on Windows and Linux. I uploaded a small
patch for a more consistent route navigation. PTAnL.

[tommycli, 2016-09-27 18:38:41]

https://codereview.chromium.org/2373613003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/reset_page/reset_page.js (right):

https://codereview.chromium.org/2373613003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/reset_page/reset_page.js:45:
settings.navigateTo(settings.Route.RESET_DIALOG);
lgtm. This seems consistent with how onClearBrowsingDataTap_ works in
privacy_page.js.

I will be interested to see how you handle the URL alias you mentioned in your
email.

[alito, 2016-09-27 18:43:01]

https://codereview.chromium.org/2373613003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/settings/reset_page/reset_page.js (right):

https://codereview.chromium.org/2373613003/diff/20001/chrome/browser/resource...
chrome/browser/resources/settings/reset_page/reset_page.js:45:
settings.navigateTo(settings.Route.RESET_DIALOG);
On 2016/09/27 18:38:41, tommycli wrote:
> lgtm. This seems consistent with how onClearBrowsingDataTap_ works in
> privacy_page.js.
> 
> I will be interested to see how you handle the URL alias you mentioned in your
> email.

:-) You will get to look at a suggestion shortly.

[alito, 2016-09-27 18:43:11]

The CQ bit was checked by alito@chromium.org

[commit-bot: I haz the power, 2016-09-27 18:44:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 18:55:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 18:56:00]

Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Dan Beam, 2016-09-27 18:59:40]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-09-27 18:59:41]

to fix the closure stuff, update
chrome/browser/resources/reset_page/compiled_resources2.gyp to include the right
routing-related targets

you can use the closure_compilation try bot to verify or locally:

third_party/closure_compilation/run_compiler

[Dan Beam, 2016-09-27 19:00:02]

On 2016/09/27 18:59:41, Dan Beam wrote:
> to fix the closure stuff, update
> chrome/browser/resources/reset_page/compiled_resources2.gyp to include the
right
> routing-related targets
> 
> you can use the closure_compilation try bot to verify or locally:
> 
> third_party/closure_compilation/run_compiler

third_party/closure_compiler/run_compiler **

[Dan Beam, 2016-09-27 19:00:31]

On 2016/09/27 18:59:41, Dan Beam wrote:
> to fix the closure stuff, update
> chrome/browser/resources/reset_page/compiled_resources2.gyp to include the
right
> routing-related targets
> 
> you can use the closure_compilation try bot to verify or locally:
> 
> third_party/closure_compilation/run_compiler

chrome/browser/resources/settings/reset_page/compiled_resources2.gyp **

damn, need more coffee

[alito, 2016-09-27 19:14:37]

Thanks Dan. Fixed the missing dependencies.

[alito, 2016-09-27 19:24:01]

The CQ bit was checked by alito@chromium.org

[alito, 2016-09-27 19:24:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2373613003/#ps40001
(title: "Fixed missing gyp dependency")

[commit-bot: I haz the power, 2016-09-27 19:24:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 20:22:11]

Description was changed from

==========
md-settings: add routing to chrome://settings/resetProfileSettings.

BUG=636408
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
md-settings: add routing to chrome://settings/resetProfileSettings.

BUG=636408
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-09-27 20:22:13]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-27 20:23:52]

Description was changed from

==========
md-settings: add routing to chrome://settings/resetProfileSettings.

BUG=636408
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
md-settings: add routing to chrome://settings/resetProfileSettings.

BUG=636408
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e8bfb7bfdf794c8f2995bd9b0da7db2f54618aca
Cr-Commit-Position: refs/heads/master@{#421317}
==========

[commit-bot: I haz the power, 2016-09-27 20:23:57]

Patchset 3 (id:??) landed as
https://crrev.com/e8bfb7bfdf794c8f2995bd9b0da7db2f54618aca
Cr-Commit-Position: refs/heads/master@{#421317}