Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(689)

Unified Diff: tools/plot-timer-events

Issue 23736004: Add better consistency check and error output to plot script. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/profviz/composer.js » ('j') | tools/profviz/composer.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/plot-timer-events
diff --git a/tools/plot-timer-events b/tools/plot-timer-events
index 0723150be5730b4414ad7843ae0b56002dacc16c..65266a23ab88761e346435bf00aabcf723bdd929 100755
--- a/tools/plot-timer-events
+++ b/tools/plot-timer-events
@@ -67,4 +67,13 @@ cat $log_file |
$tools_path/codemap.js $tools_path/profile.js $tools_path/profile_view.js \
$tools_path/logreader.js $tools_path/tickprocessor.js \
$tools_path/profviz/composer.js $tools_path/profviz/stdio.js \
- -- $@ $options 2>/dev/null | gnuplot > timer-events.png
+ -- $@ $options 2>/dev/null > timer-events.plot
+
+success=$?
+if [[ $success != 0 ]] ; then
+ cat timer-events.plot
+else
+ cat timer-events.plot | gnuplot > timer-events.png
+fi
+
+rm -rf timer-events.plot
Jakob Kummerow 2013/09/04 13:34:03 "rm -f" is enough.
Yang 2013/09/04 13:52:29 Done.
« no previous file with comments | « no previous file | tools/profviz/composer.js » ('j') | tools/profviz/composer.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698