Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Issue 2373573003: [modules] Never do lazy parsing in modules. (Closed)

Created:
4 years, 2 months ago by neis
Modified:
4 years, 2 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[modules] Never do lazy parsing in modules. If we want to allow this in the future, we must force context-allocation for all variables that are declared at the module level but not MODULE-allocated. R=adamk@chromium.org BUG=v8:1569 Committed: https://crrev.com/9f5ef0a453521a39b707c3ca6c73ca056ff7a457 Cr-Commit-Position: refs/heads/master@{#39745}

Patch Set 1 #

Patch Set 2 : Different approach. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M src/parsing/parser.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
A + test/mjsunit/modules-preparse.js View 1 chunk +7 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
neis
4 years, 2 months ago (2016-09-26 22:07:38 UTC) #1
adamk
lgtm
4 years, 2 months ago (2016-09-26 22:08:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373573003/1
4 years, 2 months ago (2016-09-26 22:09:11 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/9673) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years, 2 months ago (2016-09-26 22:26:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373573003/20001
4 years, 2 months ago (2016-09-26 22:54:03 UTC) #10
adamk
still lgtm :)
4 years, 2 months ago (2016-09-26 22:58:18 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-26 23:19:44 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 23:20:09 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9f5ef0a453521a39b707c3ca6c73ca056ff7a457
Cr-Commit-Position: refs/heads/master@{#39745}

Powered by Google App Engine
This is Rietveld 408576698