Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2000)

Unified Diff: media/filters/video_frame_scheduler.h

Issue 237353007: Refactor VideoRendererImpl to use VideoFrameScheduler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: comments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/video_frame_scheduler.h
diff --git a/media/filters/video_frame_scheduler.h b/media/filters/video_frame_scheduler.h
index 6ccebe703f71cd3f2d2e122a1320f5839d57144e..f90726211cd44d7c52a515daf7a39c151f8d2973 100644
--- a/media/filters/video_frame_scheduler.h
+++ b/media/filters/video_frame_scheduler.h
@@ -7,6 +7,7 @@
#include "base/callback.h"
#include "base/memory/ref_counted.h"
+#include "base/time/time.h"
#include "media/base/media_export.h"
namespace media {
@@ -23,18 +24,22 @@ class MEDIA_EXPORT VideoFrameScheduler {
enum Reason {
DISPLAYED, // Frame was displayed.
DROPPED, // Frame was dropped.
- RESET, // Scheduler was reset before frame was scheduled for display.
};
typedef base::Callback<void(const scoped_refptr<VideoFrame>&, Reason)> DoneCB;
// Schedule |frame| to be displayed at |wall_ticks|, firing |done_cb| when
// the scheduler has finished with the frame.
+ //
+ // To avoid reentrancy issues, |done_cb| is run on a separate calling stack.
virtual void ScheduleVideoFrame(const scoped_refptr<VideoFrame>& frame,
base::TimeTicks wall_ticks,
const DoneCB& done_cb) = 0;
- // Causes the scheduler to release all previously scheduled frames. Frames
- // will be returned as RESET.
+ // Causes the scheduler to cancel any previously scheduled frames.
+ //
+ // There is no guarantee that |done_cb|'s for previously scheduled frames
+ // will not be run. Clients should implement callback tracking/cancellation
+ // if they are sensitive to old callbacks being run.
virtual void Reset() = 0;
scherkus (not reviewing) 2014/04/25 02:04:47 I do like this style of API as it makes less guara
xhwang 2014/04/25 05:44:47 Note to myself: How does the caller know which fra
};

Powered by Google App Engine
This is Rietveld 408576698