Refactor VideoRendererImpl to use VideoFrameScheduler.

media/filters/test_video_frame_scheduler.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_FILTERS_TEST_VIDEO_FRAME_SCHEDULER_H_
+#define MEDIA_FILTERS_TEST_VIDEO_FRAME_SCHEDULER_H_
+
+#include <vector>
+
+#include "media/filters/video_frame_scheduler.h"
+
+namespace media {
+
+// A scheduler that queues frames until told otherwise.
+class TestVideoFrameScheduler : public VideoFrameScheduler {
+ public:
+  struct ScheduledFrame {
+    ScheduledFrame(const scoped_refptr<VideoFrame> frame,
+                   base::TimeTicks wall_ticks,
+                   const DoneCB& done_cb);
+    ~ScheduledFrame();
+
+    scoped_refptr<VideoFrame> frame;
+    base::TimeTicks wall_ticks;
+    DoneCB done_cb;
+  };
+
+  TestVideoFrameScheduler();
+  virtual ~TestVideoFrameScheduler();
+
+  // VideoFrameScheduler implementation.
+  virtual void ScheduleVideoFrame(const scoped_refptr<VideoFrame>& frame,
+                                  base::TimeTicks wall_ticks,
+                                  const DoneCB& done_cb) OVERRIDE;
+  virtual void Reset() OVERRIDE;
+
+  // Displays all frames with scheduled times <= |wall_ticks|.
+  void DisplayFrames(base::TimeTicks wall_ticks);

[xhwang, 2014/04/24 18:48:44]

s/DisplayFrames/DisplayFramesUpTo/ ?

[scherkus (not reviewing), 2014/04/25 02:04:47]

Done.

+
+  // Drops all frames with scheduled times <= |wall_ticks|.
+  void DropFrames(base::TimeTicks wall_ticks);

[xhwang, 2014/04/24 18:48:44]

ditto about "UpTo"

[scherkus (not reviewing), 2014/04/25 02:04:47]

Done.

+
+  void set_should_reset(bool should_reset) { should_reset_ = should_reset; }
+  const std::vector<ScheduledFrame>& scheduled_frames() {
+    return scheduled_frames_;
+  }
+
+ private:
+  void RunDoneCBForFrames(base::TimeTicks wall_ticks, Reason reason);
+
+  bool should_reset_;
+  std::vector<ScheduledFrame> scheduled_frames_;

[xhwang, 2014/04/24 18:48:44]

Any reason we don't sort the frames by timestamp? i.e. using the priority queue?

[scherkus (not reviewing), 2014/04/25 02:04:47]

it isn't required -- using a vector preserves the order in which
ScheduleVideoFrame() was called

you could argue that tests shouldn't have to worry about the order, but I do
find it easier to write/read the tests when the ordering is the same

(I don't care about this too much, so let me know if you feel otherwise)

+
+  DISALLOW_COPY_AND_ASSIGN(TestVideoFrameScheduler);
+};
+
+}  // namespace media
+
+#endif  // MEDIA_FILTERS_TEST_VIDEO_FRAME_SCHEDULER_H_