gpu/config: disable partial swaps on Mesa Gallium drivers too.

gpu/config: disable partial swaps on Mesa Gallium drivers too.

Previously detection of Mesa drivers was done by matching "Mesa" in
GL_RENDERER but Gallium-based drivers don't have "Mesa" there. Also
search for "Mesa" in GL_VERSION: all Mesa driver reported in the OpenGL
hardware database have it in GL_VERSION.

BUG=649296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d88c53039fadac470fe52e938588a259e7dcbacd
Cr-Commit-Position: refs/heads/master@{#421021}

[Corentin Wallez, 2016-09-26 14:11:09]

Description was changed from

==========
gpu/config: disable partial swaps on Mesa Gallium drivers too.

Previously detection of Mesa drivers was done by matching "Mesa" in
GL_RENDERER but Gallium-based drivers don't have "Mesa" there. Also
search for "Mesa" in GL_VERSION: all Mesa driver reported in the OpenGL
hardware database have it in GL_VERSION.

BUG=649296
==========

to

==========
gpu/config: disable partial swaps on Mesa Gallium drivers too.

Previously detection of Mesa drivers was done by matching "Mesa" in
GL_RENDERER but Gallium-based drivers don't have "Mesa" there. Also
search for "Mesa" in GL_VERSION: all Mesa driver reported in the OpenGL
hardware database have it in GL_VERSION.

BUG=649296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[Corentin Wallez, 2016-09-26 14:12:49]

cwallez@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[Corentin Wallez, 2016-09-26 14:12:49]

PTAL. We add a new entry because modifying the previous entry to match against
GL_VERSION would be too risky for a M54 merge.

[Ken Russell (switch to Gerrit), 2016-09-26 18:08:02]

lgtm

[Corentin Wallez, 2016-09-26 18:08:58]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-09-26 18:09:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 18:23:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 18:23:28]

Try jobs failed on following builders:
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[Ken Russell (switch to Gerrit), 2016-09-26 19:06:57]

https://codereview.chromium.org/2373513002/diff/1/gpu/config/gpu_driver_bug_l...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2373513002/diff/1/gpu/config/gpu_driver_bug_l...
gpu/config/gpu_driver_bug_list_json.cc:2046: },
I think the trailing ',' is what's causing the problems in the tryjobs.

[Corentin Wallez, 2016-09-26 19:10:20]

On 2016/09/26 at 19:06:57, kbr wrote:
>
https://codereview.chromium.org/2373513002/diff/1/gpu/config/gpu_driver_bug_l...
> File gpu/config/gpu_driver_bug_list_json.cc (right):
> 
>
https://codereview.chromium.org/2373513002/diff/1/gpu/config/gpu_driver_bug_l...
> gpu/config/gpu_driver_bug_list_json.cc:2046: },
> I think the trailing ',' is what's causing the problems in the tryjobs.

Thanks, fixed!

[Corentin Wallez, 2016-09-26 19:10:23]

The CQ bit was checked by cwallez@chromium.org

[Corentin Wallez, 2016-09-26 19:10:24]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/2373513002/#ps20001
(title: "gpu/config: disable partial swaps on Mesa Gallium drivers too.")

[commit-bot: I haz the power, 2016-09-26 19:11:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 19:36:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 19:36:30]

Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[Corentin Wallez, 2016-09-26 20:34:56]

On 2016/09/26 at 19:36:30, commit-bot wrote:
> Try jobs failed on following builders:
>   linux_optional_gpu_tests_rel on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

PTAL again, this adds a new matcher for the driver bug list.

[Corentin Wallez, 2016-09-26 20:35:15]

The CQ bit was checked by cwallez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-26 20:35:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ken Russell (switch to Gerrit), 2016-09-26 21:30:21]

Still LGTM

[commit-bot: I haz the power, 2016-09-26 22:03:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-26 22:03:36]

Dry run: This issue passed the CQ dry run.

[Corentin Wallez, 2016-09-26 22:26:55]

The CQ bit was checked by cwallez@chromium.org

[commit-bot: I haz the power, 2016-09-26 22:27:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-26 22:35:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-26 22:38:03]

Description was changed from

==========
gpu/config: disable partial swaps on Mesa Gallium drivers too.

Previously detection of Mesa drivers was done by matching "Mesa" in
GL_RENDERER but Gallium-based drivers don't have "Mesa" there. Also
search for "Mesa" in GL_VERSION: all Mesa driver reported in the OpenGL
hardware database have it in GL_VERSION.

BUG=649296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu/config: disable partial swaps on Mesa Gallium drivers too.

Previously detection of Mesa drivers was done by matching "Mesa" in
GL_RENDERER but Gallium-based drivers don't have "Mesa" there. Also
search for "Mesa" in GL_VERSION: all Mesa driver reported in the OpenGL
hardware database have it in GL_VERSION.

BUG=649296
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/d88c53039fadac470fe52e938588a259e7dcbacd
Cr-Commit-Position: refs/heads/master@{#421021}
==========

[commit-bot: I haz the power, 2016-09-26 22:38:04]

Patchset 3 (id:??) landed as
https://crrev.com/d88c53039fadac470fe52e938588a259e7dcbacd
Cr-Commit-Position: refs/heads/master@{#421021}