Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2373503003: Add clean up logic to navigator.credentials layout tests (Closed)

Created:
4 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 2 months ago
Reviewers:
Mike West
CC:
blink-reviews, chromium-reviews, einbinder+watch-test-runner_chromium.org, jochen+watch_chromium.org, mlamouri+watch-test-runner_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add clean up logic to navigator.credentials layout tests navigator.credentials is backed by MockCredentialManagerClient when running layout tests. If two tests are run in sequence on the same content_shell, the earlier test's configuration affects the following one. Actually, passwordcredential-fetch.html is consistently failing. Fix this by adding clean up logic to user of the mock configuration API. R=mkwst@chromium.org BUG=650561 Committed: https://crrev.com/5138b3b9ec53fd1cea8ff4e9da8389ef71b79c2f Cr-Commit-Position: refs/heads/master@{#421155}

Patch Set 1 #

Messages

Total messages: 13 (9 generated)
Mike West
LGTM, thanks!
4 years, 2 months ago (2016-09-27 08:25:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373503003/1
4 years, 2 months ago (2016-09-27 09:07:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 09:12:09 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 09:13:26 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5138b3b9ec53fd1cea8ff4e9da8389ef71b79c2f
Cr-Commit-Position: refs/heads/master@{#421155}

Powered by Google App Engine
This is Rietveld 408576698