chrome://inspect: Fix 'inspect' link for local targets

chrome/browser/resources/inspect/inspect.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var MIN_VERSION_TAB_CLOSE = 25;
 var MIN_VERSION_TARGET_ID = 26;
 var MIN_VERSION_NEW_TAB = 29;
 var MIN_VERSION_TAB_ACTIVATE = 30;
 
 function inspect(data) {
@@ skipping 260 matching lines @@
         pageList.className = 'list pages';
         browserSection.appendChild(pageList);
       }
 
       if (alreadyDisplayed(browserSection, browser))
         continue;
 
       pageList.textContent = '';
       for (var p = 0; p < browser.pages.length; p++) {
         var page = browser.pages[p];
-        // Attached targets have no unique id until Chrome 26.
-        // For such targets it is impossible:
-        //  - to issue 'close' command,
-        //  - to activate existing DevTools window.
-        page.hasUniqueId = !page.attached ||
-            majorChromeVersion >= MIN_VERSION_TARGET_ID;
+        // Attached targets have no unique id until Chrome 26. For such targets
+        // it is impossible to activate existing DevTools window.
+        page.hasNoUniqueId = page.attached &&
+            majorChromeVersion < MIN_VERSION_TARGET_ID;
         var row = addTargetToList(
             page, pageList, ['faviconUrl', 'name', 'url', 'description']);
         if (isChrome) {
           if (majorChromeVersion >= MIN_VERSION_TAB_ACTIVATE) {
             row.appendChild(createActionLink(
                 'activate', activate.bind(null, page), false));
           }
           row.appendChild(createActionLink(
               'reload', reload.bind(null, page), page.attached));
           if (majorChromeVersion >= MIN_VERSION_TAB_CLOSE) {
             row.appendChild(createActionLink(
-                'close',
-                terminate.bind(null, page),
-                page.attached || !page.hasUniqueId));
+                'close', terminate.bind(null, page), page.attached));
           }
         }
       }
     }
   }
 }
 
 function addToPagesList(data) {
   addTargetToList(data, $('pages-list'), ['faviconUrl', 'name', 'url']);
 }
@@ skipping 84 matching lines @@
       try {
         description = JSON.parse(data['description']);
       } catch (e) {}
     }
   }
 
   if (description)
     addWebViewDescription(description, row);
 
   row.appendChild(createActionLink(
-      'inspect', inspect.bind(null, data), !data.hasUniqueId));
+      'inspect', inspect.bind(null, data), data.hasNoUniqueId));
 
   list.appendChild(row);
   return row;
 }
 
 function createActionLink(text, handler, opt_disabled) {
   var link = document.createElement('a');
   if (opt_disabled)
     link.classList.add('disabled');
   else
@@ skipping 230 matching lines @@
   if (line.querySelector('.invalid'))
     return;
   line.classList.remove('fresh');
   var freshLine = createEmptyConfigLine();
   line.parentNode.appendChild(freshLine);
   if (opt_selectNew)
     freshLine.querySelector('.port').focus();
 }
 
 document.addEventListener('DOMContentLoaded', onload);