Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 2373473003: Separate ARC++ Provisioning Histogram into managed and unmanaged (Closed)

Created:
4 years, 2 months ago by phweiss
Modified:
4 years, 2 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, asvitkine+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Separate ARC++ Provisioning Histogram into managed and unmanaged Deprecate "Arc.Provisioning.Result" and replace it by "Arc.Provisioning.Result.Managed" and "Arc.Provisioning.Result.Unmanaged" for more detailed feedback. BUG=647670 BUG=b/31442315 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2339393002 Cr-Commit-Position: refs/heads/master@{#420322} (cherry picked from commit 1ca52852f992b97cf3bfefff7e70a605ed2295bc)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -6 lines) Patch
M chrome/browser/chromeos/arc/arc_auth_service.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/arc/arc_optin_uma.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/arc/arc_optin_uma.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +23 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (12 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373473003/1
4 years, 2 months ago (2016-09-27 08:32:44 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-09-27 08:32:46 UTC) #8
phweiss
Hi Luis, ptal, this is the merge to M54 of the CL you already reviewed.
4 years, 2 months ago (2016-09-27 08:36:02 UTC) #10
Luis Héctor Chávez
rs-lgtm
4 years, 2 months ago (2016-09-27 14:46:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373473003/1
4 years, 2 months ago (2016-09-27 14:48:14 UTC) #13
commit-bot: I haz the power
CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true and NOPRESUBMIT=true in order for ...
4 years, 2 months ago (2016-09-27 14:48:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373473003/1
4 years, 2 months ago (2016-09-27 14:49:59 UTC) #18
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 14:53:12 UTC) #20
Message was sent while issue was closed.
Committed patchset #1 (id:1)

Powered by Google App Engine
This is Rietveld 408576698