Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2373453002: [turbofan] Fix restriction type for modulus in representation inference. (Closed)

Created:
4 years, 2 months ago by Jarin
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix restriction type for modulus in representation inference. BUG=chromium:650215 Committed: https://crrev.com/3218ef30b8c8fe6622ec8d03b634a7fd992ef5af Cr-Commit-Position: refs/heads/master@{#39715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M src/compiler/simplified-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + test/mjsunit/compiler/regress-650215.js View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Jarin
Could you take a look, please?
4 years, 2 months ago (2016-09-26 10:35:52 UTC) #5
Benedikt Meurer
LGTM, thanks.
4 years, 2 months ago (2016-09-26 10:38:09 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373453002/1
4 years, 2 months ago (2016-09-26 11:42:37 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 11:44:56 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 11:45:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3218ef30b8c8fe6622ec8d03b634a7fd992ef5af
Cr-Commit-Position: refs/heads/master@{#39715}

Powered by Google App Engine
This is Rietveld 408576698