Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2373443002: predictors: Key the resource prefetcher by URL, not navigation. (Closed)

Created:
4 years, 2 months ago by Benoit L
Modified:
4 years, 2 months ago
Reviewers:
pasko
CC:
chromium-reviews, shishir+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

predictors: Key the resource prefetcher by URL, not navigation. The resource prefetcher is currently keyed by navigation. It is now keyed by URL, which is the only piece of data used from the navigation. Aside from less coupling, this opens the door to trigger prefetches before a navigation starts. This commit also removes the possibility of having two concurrent prefetches running for the same host. Aside from being rare, this is not desirable as a lot of resources are expected to be shared across two URLs on the same domain. Thus, a prefetch B can unintentionally use a resource prefetched by a prefetch A from the same domain, negating the prefetch (since LOAD_PREFETCH resources can only be used once without revalidation). BUG=631966 Committed: https://crrev.com/72fec99e143cd8fa697e04ad32bc6be4dc9c6c8e Cr-Commit-Position: refs/heads/master@{#420898}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -51 lines) Patch
M chrome/browser/predictors/resource_prefetch_predictor.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/predictors/resource_prefetcher.h View 3 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher_manager.h View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher_manager.cc View 2 chunks +12 lines, -22 lines 0 comments Download
M chrome/browser/predictors/resource_prefetcher_unittest.cc View 5 chunks +8 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Benoit L
4 years, 2 months ago (2016-09-26 09:52:56 UTC) #2
pasko
lgtm!
4 years, 2 months ago (2016-09-26 14:37:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2373443002/1
4 years, 2 months ago (2016-09-26 15:59:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-26 16:05:16 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-26 16:07:53 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/72fec99e143cd8fa697e04ad32bc6be4dc9c6c8e
Cr-Commit-Position: refs/heads/master@{#420898}

Powered by Google App Engine
This is Rietveld 408576698