Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: tools/perf/page_sets/system_health/long_running_stories.py

Issue 2373293003: Disable long-running gmail stories on svelte (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/system_health/long_running_stories.py
diff --git a/tools/perf/page_sets/system_health/long_running_stories.py b/tools/perf/page_sets/system_health/long_running_stories.py
index 2a70985470e68b495adb9a21a09f520106b3361c..d2221ce60aa71c2ab5b767e92fc38670c0fe9259 100644
--- a/tools/perf/page_sets/system_health/long_running_stories.py
+++ b/tools/perf/page_sets/system_health/long_running_stories.py
@@ -58,6 +58,13 @@ class _LongRunningGmailBase(_LongRunningStory):
class _LongRunningGmailMobileBase(_LongRunningGmailBase):
SUPPORTED_PLATFORMS = platforms.MOBILE_ONLY
+ @classmethod
+ def ShouldDisable(cls, possible_browser):
+ # crbug.com/651198
+ if cls.IsSvelte(possible_browser):
nednguyen 2016/09/28 20:37:56 we have IsSvelte defined as a class for benchmark,
sullivan 2016/09/28 20:53:21 Done.
+ return True
+ return False
+
def _DidLoadDocument(self, action_runner):
# Close the "Get Inbox by Gmail" interstitial.
action_runner.WaitForJavaScriptCondition(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698