Disable long-running gmail stories on svelte

Disable long-running gmail stories on svelte

BUG=651198
Committed: https://crrev.com/d4d25d0ed32a0a128e15ecfcd5d707ea571f6f56
Cr-Commit-Position: refs/heads/master@{#421649}

[sullivan, 2016-09-28 20:35:00]

sullivan@chromium.org changed reviewers:
+ nednguyen@google.com

[sullivan, 2016-09-28 20:35:01]

Please review carefully, first time I've disabled like this in a page set.

[nednguyen, 2016-09-28 20:37:56]

lgtm

https://codereview.chromium.org/2373293003/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/long_running_stories.py (right):

https://codereview.chromium.org/2373293003/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/long_running_stories.py:64: if
cls.IsSvelte(possible_browser):
we have IsSvelte defined as a class for benchmark, not for system health page.
So you still need to go the long path:

"if possible_browser.platform.IsSvelte()"

Also why not just: "return possible_browser.platform.IsSvelte()"

[sullivan, 2016-09-28 20:53:22]

https://codereview.chromium.org/2373293003/diff/1/tools/perf/page_sets/system...
File tools/perf/page_sets/system_health/long_running_stories.py (right):

https://codereview.chromium.org/2373293003/diff/1/tools/perf/page_sets/system...
tools/perf/page_sets/system_health/long_running_stories.py:64: if
cls.IsSvelte(possible_browser):
On 2016/09/28 20:37:56, nednguyen wrote:
> we have IsSvelte defined as a class for benchmark, not for system health page.
> So you still need to go the long path:
> 
> "if possible_browser.platform.IsSvelte()"
> 
> Also why not just: "return possible_browser.platform.IsSvelte()"

Done.

[sullivan, 2016-09-28 20:53:25]

The CQ bit was checked by sullivan@chromium.org

[sullivan, 2016-09-28 20:53:25]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/2373293003/#ps20001
(title: "address review comments")

[commit-bot: I haz the power, 2016-09-28 20:53:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 21:47:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-28 21:50:50]

Description was changed from

==========
Disable long-running gmail stories on svelte

BUG=651198
==========

to

==========
Disable long-running gmail stories on svelte

BUG=651198

Committed: https://crrev.com/d4d25d0ed32a0a128e15ecfcd5d707ea571f6f56
Cr-Commit-Position: refs/heads/master@{#421649}
==========

[commit-bot: I haz the power, 2016-09-28 21:50:51]

Patchset 2 (id:??) landed as
https://crrev.com/d4d25d0ed32a0a128e15ecfcd5d707ea571f6f56
Cr-Commit-Position: refs/heads/master@{#421649}