chrome/browser/crash_recovery_browsertest.cc - Issue 2373273002: Run unload handlers when navigating to about:blank using PlzNavigate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/crash_recovery_browsertest.cc

Issue 2373273002: Run unload handlers when navigating to about:blank using PlzNavigate. (Closed)

Patch Set: undo incorrect change that broke chrome://crash Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/crash_recovery_browsertest.cc

diff --git a/chrome/browser/crash_recovery_browsertest.cc b/chrome/browser/crash_recovery_browsertest.cc

index d9702e651938fbc7f3e296e3450695bfc1f253aa..9634546b07c78bd244ad3e08d1ae1ee4c992f3fb 100644

--- a/chrome/browser/crash_recovery_browsertest.cc

+++ b/chrome/browser/crash_recovery_browsertest.cc

@@ -176,6 +176,18 @@ IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, DoubleReloadWithError) {

ASSERT_EQ(url, GetActiveWebContents()->GetVisibleURL());

}

+// Tests that a beforeunload handler doesn't run if user navigates to

+// chrome::crash.

+IN_PROC_BROWSER_TEST_F(CrashRecoveryBrowserTest, BeforeUnloadNotRun) {

+ const char* kBeforeUnloadHTML =

+ "<html><body>"

+ "<script>window.onbeforeunload=function(e){return 'foo'}</script>"

+ "</body></html>";

+ GURL url(std::string("data:text/html,") + kBeforeUnloadHTML);

+ ui_test_utils::NavigateToURL(browser(), url);

+ SimulateRendererCrash(browser());

} // namespace

#endif

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_resource_request_policy_apitest.cc » ('j') | no next file with comments »